Skip to content

Created noThrow Wrapper for which(), Fixed Arch Map for MSVC #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diefbell-grabcad wants to merge 9 commits into
base: master
Choose a base branch
from
+80 −37
Open

Created noThrow Wrapper for which(), Fixed Arch Map for MSVC #60

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
524e0ac
Bumped version of `which`, bumped `cmake-ts`'s version
diefbell-grabcad May 28, 2025
59002f4
Added minimum Node version engine requirement
diefbell-grabcad May 28, 2025
2a35885
Upgraded which version, idk how it ended up not being in the PR
diefbell-grabcad May 28, 2025
06b096e
Undid pnpm's reformat
diefbell-grabcad May 28, 2025
3329751
Updated lockfile
diefbell-grabcad May 28, 2025
6c51e2c
Reverted `which` to version 2, manually handling `which` throwing
diefbell-grabcad Apr 1, 2026
ddcf84c
Corrected logging for generator and generator flags
diefbell-grabcad Apr 1, 2026
f122639
Corrected architecture arg map for msvc
diefbell-grabcad Apr 2, 2026
5823edb
Documented `generatorToUse` and `generatorFlags`
diefbell-grabcad Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions package.json
View file
Open in desktop

@diefbell-grabcad diefbell-grabcad May 28, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm add which@3.0.1 decided it needed to reformat the entire file

@diefbell-grabcad diefbell-grabcad May 28, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which then made linting fail 🤦

@aminya aminya Apr 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. I can fix that

Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
{
"name": "cmake-ts",
"version": "1.0.2",
"version": "1.0.3",
"description": "cmake-js rewrite in typescript to support advanced build configurations",
"main": "build/lib.js",
"module": "build/lib.mjs",
"engines": {
"node": ">= 18"
},
"exports": {
".": {
"require": "./build/lib.js",
Expand Down Expand Up @@ -116,7 +119,7 @@
"semver": "^7.7.1",
"tar": "^6",
"url-join": "^4.0.1",
"which": "^2",
"which": "3.0.1",
"node-downloader-helper": "^2.1.9",
"escape-quotes": "^1.0.2",
"commander": "^13.1.0",
Expand Down
13 changes: 11 additions & 2 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading