Skip to content

cfg: reuse original ControlRegions as much as possible during structurization. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fornwall merged 5 commits into from
Jan 31, 2024
Merged

cfg: reuse original ControlRegions as much as possible during structurization. #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f3c27aa
cfg: lazily propagate deferred conditions, during structurization.
eddyb Dec 14, 2023
c673ef8
cfg: don't keep targets in both the keys and values of a `DeferredEdg…
eddyb Dec 14, 2023
96d869f
cfg: remove `deferred_return` in favor of `deferred_edges` tracking r…
eddyb Dec 14, 2023
549a62b
cfg: reuse original `ControlRegion`s as much as possible during struc…
eddyb Sep 5, 2023
9fa349c
Add changelog entry
fornwall Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased] - ReleaseDate

### Changed 🛠
- [PR#55](https://github.com/EmbarkStudios/spirt/pull/55) fixed CFG structurization
"region `children` list desync" assertion failures (e.g. [rust-gpu#1086](https://github.com/EmbarkStudios/rust-gpu/issues/1086))
by tracking whole `ControlRegion`s instead of their `children`
- also removed a lot of redundant boolean values, thanks to condition propagation
becoming always on-demand (instead of relying on less robust special-casing)
- [PR#51](https://github.com/EmbarkStudios/spirt/pull/51) combined `TypeCtor`/`ConstCtor`
and their respective "ctor args", into a single unified `TypeKind`/`ConstKind`
- [PR#48](https://github.com/EmbarkStudios/spirt/pull/48) changed CFG structurization
Expand Down
14 changes: 7 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,15 +140,15 @@ global_var GV0 in spv.StorageClass.Output: s32
func F0() -> spv.OpTypeVoid {
loop(v0: s32 <- 1s32, v1: s32 <- 1s32) {
v2 = spv.OpSLessThan(v1, 10s32): bool
(v3: bool, v4: s32, v5: s32, _: bool) = if v2 {
v6 = spv.OpIMul(v0, v1): s32
v7 = spv.OpIAdd(v1, 1s32): s32
(true, v6, v7, false)
(v3: s32, v4: s32) = if v2 {
v5 = spv.OpIMul(v0, v1): s32
v6 = spv.OpIAdd(v1, 1s32): s32
(v5, v6)
} else {
(false, spv.OpUndef: s32, spv.OpUndef: s32, true)
(spv.OpUndef: s32, spv.OpUndef: s32)
}
(v4, v5) -> (v0, v1)
} while v3
(v3, v4) -> (v0, v1)
} while v2
spv.OpStore(Pointer: &GV0, Object: v0)
}
```
Expand Down
Loading