Expose ECDSA sign-to-contract and Anti-Klepto protocol functions#259
Merged
jgriffiths merged 14 commits intoElementsProject:masterfrom Jan 11, 2021
Merged
Conversation
jgriffiths
reviewed
Jan 8, 2021
LeoComandini
force-pushed
the
2021-01-05-s2c-anti-klepto
branch
from
bfa725c to
d37773d
Compare
Contributor
Author
|
Addressed the comments and rearranged the commits, which had some issues. |
Contributor
|
Pretty close to the ideal PR now, thanks! There's only one issue left that stands out after building locally; the new functions need to be wrapped in the Java I will be merging #257 shortly and I've added a test to it that will fail when unwrapped Java calls are present so this gets caught automatically going forward. |
Currently only support ecdsa sign-to-contract (s2c). Schnorr support might be added later.
LeoComandini
force-pushed
the
2021-01-05-s2c-anti-klepto
branch
from
d37773d to
fe326a2
Compare
Closed
Contributor
|
secp256k1_ecdsa_s2c.h is only present in secp256k1-zkp so it would be nice to make this feature optional, see #299. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose functionalities added in BlockstreamResearch/secp256k1-zkp#111
Added a section in "Developer Guides" with an example of the Anti-Klepto protocol.