Skip to content

Use detection bin symmetry in efficiencies and alive-time - #195

Merged
KrisThielemans merged 8 commits into
mainfrom
useModuleSymmetry
Aug 17, 2026
Merged

Use detection bin symmetry in efficiencies and alive-time#195
KrisThielemans merged 8 commits into
mainfrom
useModuleSymmetry

Conversation

@KrisThielemans

@KrisThielemans KrisThielemans commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #138
Fixes #171
Fixes #157

Also

  • renamed moduleCoincidenceAliveTimeFractions to modulePairAliveTimeFractions for consistency with modulePairEfficiencies
  • changed SGID type from uint to int, as we use -1 to denote "not in coincidence"

@KrisThielemans KrisThielemans self-assigned this Jul 24, 2026
@KrisThielemans KrisThielemans added the enhancement New feature or request label Jul 24, 2026
@KrisThielemans KrisThielemans changed the title Use module symmetry Use detection bin symmetry in efficiencies and alive-time Jul 24, 2026
@KrisThielemans

KrisThielemans commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Model changes and C++ hopefully finished. Python still to do.

@KrisThielemans

Copy link
Copy Markdown
Contributor Author

Current status:

Comment thread model/DetectionEfficiencies.yml Outdated
Also add helper functions to check, and assert/correct
in get_detection_efficiency
@KrisThielemans
KrisThielemans merged commit 7c96a71 into main Aug 17, 2026
2 checks passed
@KrisThielemans
KrisThielemans deleted the useModuleSymmetry branch August 17, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

1 participant