Use detection bin symmetry in efficiencies and alive-time - #195
Merged
Conversation
KrisThielemans
force-pushed
the
useModuleSymmetry
branch
from
July 24, 2026 16:36
8b11ad2 to
9eadde5
Compare
Contributor
Author
|
Model changes and C++ hopefully finished. Python still to do. |
KrisThielemans
force-pushed
the
useModuleSymmetry
branch
from
August 4, 2026 07:49
1d7016a to
1c3b7bd
Compare
This is consistent with modulePairEfficiencies
run-time failure
KrisThielemans
force-pushed
the
useModuleSymmetry
branch
from
August 4, 2026 07:54
1c3b7bd to
7196b93
Compare
Contributor
Author
|
Current status:
|
KrisThielemans
commented
Aug 14, 2026
Also add helper functions to check, and assert/correct in get_detection_efficiency
KrisThielemans
force-pushed
the
useModuleSymmetry
branch
from
August 17, 2026 19:24
ab7f16f to
9581d92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138
Fixes #171
Fixes #157
Also
moduleCoincidenceAliveTimeFractionstomodulePairAliveTimeFractionsfor consistency withmodulePairEfficienciesSGIDtype fromuinttoint, as we use -1 to denote "not in coincidence"