Conversation
…_skin_temperature" definition, and return proper skin temperature naming accordingly
…see if this sticks...
…ned "friction-temperature", including definition and citation.
…r "at_surface_interface" due to existing conflicting definition of "bottom-of-atmosphere" in radiation community. Will stick with the slightly more ambiguous but overall less confusing "at_surface" as a synonym for "at_surface_interface", with appropriate definitions.
mkavulich
requested review from
MarekWlasak,
cacraigucar,
climbfuji,
dustinswales,
grantfirl,
nusbaume,
peverwhee,
ss421 and
svahl991
as code owners
September 22, 2026 15:14
climbfuji
reviewed
Sep 22, 2026
Collaborator
Author
|
@svahl991 Here is the pull request for your review. There are a few changes since the last time I checked in:
|
mkavulich
force-pushed
the
feature/resolve_surface_names_rules
branch
from
September 22, 2026 19:06
b211c59 to
36899d1
Compare
Collaborator
Author
|
@climbfuji Thanks for your review; note I pushed one more change with additional "skin_temperature" variables after your review. I've also updated the figure to use |
climbfuji
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to resolve several open issues:
surfaceall together when unnecessary (e.g.surface_friction_velocity-->friction_velocity)surface_skin_temperature,sea_surface_skin_temperature, andskin_temperature_at_toa, with detailed comments on the definitions for each.In addition to these issues, additional clarity is added to the rules for definitions of "layer" vs "interface" (including a fancy diagram!), and the term
surface_temperature_scaleis renamed to the synonymous and less ambiguousfriction_temperature.Issues
Resolves: