[hls-fuzzer] Migrate remaining check* methods to transfer API#893
[hls-fuzzer] Migrate remaining check* methods to transfer API#893
check* methods to transfer API#893Conversation
This PR migrates the remaining `check*` methods to the new transfer API and removes all related documentation. Most check methods can easily be adapted to discard methods with only some simple logic implemented in transfer functions. Notably, the scheme for terminals remain where optionals with replacements are returned instead.
| } // namespace dynamatic | ||
|
|
||
| // Enable 'dyn_cast' and friends on 'ScalarType' by delegating to 'dyn_cast' on | ||
| // the variant. |
There was a problem hiding this comment.
So we don’t need to use std::get_if?
Give an example?
There was a problem hiding this comment.
Correct. The std::variant is a complete implementation detail of ScalarType.
|
who does the job of "typesystemtraits" now? |
All information that the generator needs is now specified via the |
|
Btw maybe we rename basic c generator to just c generator: basic implies either this is a base class or there are more advanced generators… |
2 participants
This PR migrates the remaining
check*methods to the new transfer API and removes all related documentation.Most check methods can easily be adapted to discard methods with only some simple logic implemented in transfer functions. Notably, the scheme for terminals remain where optionals with replacements are returned instead.