Skip to content

DYN-10717 Fix the Save/Save As menu items hardcoded #17255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edwin-vasquez-ucaldas wants to merge 8 commits into
base: master
Choose a base branch
from
Open

DYN-10717 Fix the Save/Save As menu items hardcoded #17255

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
05e4210
Fix the Save/Save As menu items hardcoded IsEnabled="False" in XAML
edwin-vasquez-ucaldas Jul 28, 2026
302d8c9
Adding unit tests
edwin-vasquez-ucaldas Jul 29, 2026
9db01b0
Fix unit test
edwin-vasquez-ucaldas Jul 29, 2026
eb2fb46
call OnWorkspaceOpened/raise RequestEnableShortcutBarItems(true) fro…
edwin-vasquez-ucaldas Jul 29, 2026
acdb691
Sync Save/Save As enablement across menu, hotkey, and toolbar via sha…
edwin-vasquez-ucaldas Jul 30, 2026
91f0700
Correctly reverted — this file is now staged with exactly the inverse…
edwin-vasquez-ucaldas Jul 30, 2026
7d50b3e
Merge branch 'master' into DYN-10717_Fix_disabled_Save_and_Save_As_op…
RobertGlobant20 Jul 30, 2026
aed88c5
Fixing tests were failing. Add new test focus into the Guided Tour
edwin-vasquez-ucaldas Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions doc/distrib/xml/en-US/DSCoreNodes.xml
View file
Open in desktop
Comment thread
edwin-vasquez-ucaldas marked this conversation as resolved.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions src/DynamoCoreWpf/Views/Core/DynamoView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,13 +354,11 @@
<MenuItem Name="saveThisButton"
Command="{Binding ShowSaveDialogIfNeededAndSaveResultCommand}"
Header="{x:Static p:Resources.DynamoViewFileMenuSave}"
InputGestureText="Ctrl + S"
IsEnabled="False" />
Comment thread
edwin-vasquez-ucaldas marked this conversation as resolved.
InputGestureText="Ctrl + S" />
<MenuItem Name="saveButton"
Command="{Binding ShowSaveDialogAndSaveResultCommand}"
Header="{x:Static p:Resources.DynamoViewFileMenuSaveAs}"
InputGestureText="Ctrl + Shift + S"
IsEnabled="False" />
InputGestureText="Ctrl + Shift + S" />
<Separator />
<MenuItem Name="importLibrary"
Command="{Binding Path=DataContext.ImportLibraryCommand, RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type controls:DynamoView}}}"
Expand Down
11 changes: 0 additions & 11 deletions src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,11 +435,6 @@ void DynamoView_MouseLeftButtonDown(object sender, MouseButtonEventArgs e)

private void DynamoViewModel_RequestEnableShortcutBarItems(bool enable)
{
if (!(saveThisButton is null))
{
saveThisButton.IsEnabled = enable;
saveButton.IsEnabled = enable;
}
if (!(exportMenu is null))
{
exportMenu.IsEnabled = enable;
Comment thread
edwin-vasquez-ucaldas marked this conversation as resolved.
Expand Down Expand Up @@ -471,12 +466,6 @@ private void DynamoViewModel_RequestEnableShortcutBarItems(bool enable)

private void OnWorkspaceOpened(WorkspaceModel workspace)
{
if (!(saveThisButton is null))
{
saveThisButton.IsEnabled = true;
saveButton.IsEnabled = true;
}

if (!(exportMenu is null))
{
exportMenu.IsEnabled = true;
Expand Down
25 changes: 25 additions & 0 deletions test/DynamoCoreWpfTests/DynamoViewTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,31 @@ public void TestHomeWorkspaceClosedBeforeCustomNode()
Assert.IsTrue(View.saveButton.IsEnabled);
}

[Test]
public void WhenDynamoLaunchesThenSaveMenuItemsAreEnabled()
{
// Regression test for DYN-10717: the File > Save and Save As menu items were
// hardcoded IsEnabled="False" in XAML and only re-enabled via events that never
// fire for the workspace created at startup (it is never "Opened" from a file).
Assert.IsTrue(View.saveThisButton.IsEnabled);
Assert.IsTrue(View.saveButton.IsEnabled);
}

[Test]
public void WhenLastWorkspaceIsClosedThenSaveMenuItemsRemainEnabled()
{
// Regression test for DYN-10717: closing the only open workspace returns to the
// start page; the Save/Save As menu items should remain enabled for the fresh
// workspace left behind (Ctrl+S already worked in this state before the fix).
DynamoModel.IsTestMode = false;
ViewModel.CloseHomeWorkspaceCommand.Execute(null);
DynamoModel.IsTestMode = true;

Assert.IsTrue(ViewModel.ShowStartPage);
Assert.IsTrue(View.saveThisButton.IsEnabled);
Assert.IsTrue(View.saveButton.IsEnabled);
}

[Test]
public void ElementBinding_SaveAs()
{
Expand Down
Loading