Skip to content

DYN-10716: Disable Autodesk Assistant when IDSDK is not initialized #17251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eamiri wants to merge 5 commits into
base: master
Choose a base branch
from
+223 −0
Open

DYN-10716: Disable Autodesk Assistant when IDSDK is not initialized #17251

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f09b38d
DYN-10716: Disable Autodesk Assistant when IDSDK is not initialized
eamiri Jul 27, 2026
c7de5c8
DYN-10716: Disable (not hide) Autodesk Assistant tab when IDSDK not i…
eamiri Jul 27, 2026
408361e
DYN-10716: Re-disable AA tab on any new SideBarTabItems Add
eamiri Jul 27, 2026
c9efe64
DYN-10716: Block AA tab in AddOrFocusExtensionControl under NoNetwork…
eamiri Jul 27, 2026
64a6ec6
DYN-10716: Fix missing System.Linq using in test file
eamiri Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3403,12 +3403,21 @@ public void Dispose()

internal bool DisableExtensionWhenNoNetworkMode(string extensionId, string extensionName, string action)
{
if (dynamoViewModel.Model.NoNetworkMode &&
(string.Equals(extensionId, AutodeskAssistantExtensionId, StringComparison.OrdinalIgnoreCase) ||
string.Equals(extensionId, McpViewExtensionId, StringComparison.OrdinalIgnoreCase)))
if (!string.Equals(extensionId, AutodeskAssistantExtensionId, StringComparison.OrdinalIgnoreCase) &&
!string.Equals(extensionId, McpViewExtensionId, StringComparison.OrdinalIgnoreCase))
{
return false;
}

if (dynamoViewModel.Model.NoNetworkMode)
{
Log($"Package/Extension {extensionName} not {action} because NoNetworkMode flag is active");
return true;
}

if (!dynamoViewModel.Model.AuthenticationManager.IsIDSDKInitialized())
{
Log($"Package/Extension {extensionName} not {action} because IDSDK is not initialized");
return true;
}

Expand Down
101 changes: 101 additions & 0 deletions test/DynamoCoreWpfTests/DynamoViewNoNetworkModeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Dynamo.Controls;
using Dynamo.Core;
using Dynamo.Models;
using Dynamo.ViewModels;
using NUnit.Framework;
Expand Down Expand Up @@ -100,5 +101,105 @@ public void UnrecognizedExtensionIsNotDisabledWhenNoNetworkModeIsEnabled()

Assert.IsFalse(shouldDisable);
}

[Test]

@jasonstratton jasonstratton Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests assume the IDSDK is unavailable, but on a test machine or a dev machine, it might be installed and fail.

Add Assume.That(!...IsIDSDKInitialized()) or Assert.Ignore

public void AutodeskAssistantExtensionIsDisabledWhenIDSDKIsNotInitialized()
{
var pathResolver = new TestPathResolver();
DynamoModel modelWithUninitializedIDSDK = null;
DynamoViewModel viewModelWithUninitializedIDSDK = null;
DynamoView viewWithUninitializedIDSDK = null;

try
{
// IDSDKManager.IsIDSDKInitialized returns false when the native IDSDK library
// is not installed (e.g. test environments, VMs without Autodesk Identity).
modelWithUninitializedIDSDK = DynamoModel.Start(new DynamoModel.DefaultStartConfiguration()
{
PathResolver = pathResolver,
StartInTestMode = true,
GeometryFactoryPath = preloader.GeometryFactoryPath,
ProcessMode = Dynamo.Scheduler.TaskProcessMode.Synchronous,
NoNetworkMode = false,
AuthProvider = new IDSDKManager()
});

Comment on lines +128 to +129
viewModelWithUninitializedIDSDK = DynamoViewModel.Start(new DynamoViewModel.StartConfiguration()
{
DynamoModel = modelWithUninitializedIDSDK
});

viewWithUninitializedIDSDK = new DynamoView(viewModelWithUninitializedIDSDK);

var shouldDisable = viewWithUninitializedIDSDK.DisableExtensionWhenNoNetworkMode(
DynamoView.AutodeskAssistantExtensionId,
"Autodesk Assistant",
"added");

Assert.IsTrue(shouldDisable);
}
finally
{
if (viewWithUninitializedIDSDK != null && viewWithUninitializedIDSDK.IsLoaded)
{
viewWithUninitializedIDSDK.Close();
}

if (viewModelWithUninitializedIDSDK != null)
{
var shutdownParams = new DynamoViewModel.ShutdownParams(shutdownHost: false, allowCancellation: false);
viewModelWithUninitializedIDSDK.PerformShutdownSequence(shutdownParams);
}
}
}

[Test]
public void McpViewExtensionIsDisabledWhenIDSDKIsNotInitialized()
{
var pathResolver = new TestPathResolver();
DynamoModel modelWithUninitializedIDSDK = null;
DynamoViewModel viewModelWithUninitializedIDSDK = null;
DynamoView viewWithUninitializedIDSDK = null;

try
{
modelWithUninitializedIDSDK = DynamoModel.Start(new DynamoModel.DefaultStartConfiguration()
{
PathResolver = pathResolver,
StartInTestMode = true,
GeometryFactoryPath = preloader.GeometryFactoryPath,
ProcessMode = Dynamo.Scheduler.TaskProcessMode.Synchronous,
NoNetworkMode = false,
AuthProvider = new IDSDKManager()
});

viewModelWithUninitializedIDSDK = DynamoViewModel.Start(new DynamoViewModel.StartConfiguration()
{
DynamoModel = modelWithUninitializedIDSDK
});

viewWithUninitializedIDSDK = new DynamoView(viewModelWithUninitializedIDSDK);

var shouldDisable = viewWithUninitializedIDSDK.DisableExtensionWhenNoNetworkMode(
DynamoView.McpViewExtensionId,
"Dynamo MCP View Extension",
"added");

Assert.IsTrue(shouldDisable);
}
finally
{
if (viewWithUninitializedIDSDK != null && viewWithUninitializedIDSDK.IsLoaded)
{
viewWithUninitializedIDSDK.Close();
}

if (viewModelWithUninitializedIDSDK != null)
{
var shutdownParams = new DynamoViewModel.ShutdownParams(shutdownHost: false, allowCancellation: false);
viewModelWithUninitializedIDSDK.PerformShutdownSequence(shutdownParams);
}
}
}
}
}
Loading