DYN-10430: Fix DesignScript ToString() method not found in code block nodes

[Copilot]

Calling ToString(x) in a DesignScript code block produced "Method 'ToString()' not found" and returned null. The engine only registered internal __ToStringFromObject/__ToStringFromObjectAndFormat built-ins (double-underscore prefix = implementation-internal); no public ToString was ever wired up, despite being documented in BuiltIn.xml.

def tostr(pt : Point)
{
    // Previously: "Method 'ToString()' not found" + nulls
    return = ToString(pt.X) + "," + ToString(pt.Y) + "," + ToString(pt.Z);
};

Changes

• BuiltInMethods.cs — Added ToString to MethodID enum and the parallel methodNames array (index-ordered); registered a BuiltInMethod entry with a single rank-0 var parameter (DesignScript replication handles lists automatically)
• BuiltInFunctionEndPoint.cs — Added MethodID.ToString to the existing ToStringFromObject/ToStringFromArray dispatch case, delegating to StringUtils.ConvertToString(formalParameters[0], ...)
• StringTest.cs — Added tests for int, double, bool inputs and ToString used inside a function body

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10430

[zeusongit]

@ivaylo-matov I asked the agent to look at this issue, does the fix make sense to you here?

[ivaylo-matov]

Thanks, @zeusongit
I'll look into that.

[Copilot]

Pull request overview

Fixes DesignScript code block resolution for the documented ToString(...) built-in by wiring a public ToString method ID to the existing string-conversion implementation and adding regression tests.

Changes:

• Added MethodID.ToString plus the corresponding "ToString" entry in the built-in method name table, and registered it as a built-in method returning string.
• Routed MethodID.ToString execution through the existing ToStringFromObject/ToStringFromArray conversion path (StringUtils.ConvertToString).
• Added smoke tests covering ToString for int, double, bool, and use within a function body.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
test/Engine/ProtoTest/TD/MultiLangTests/StringTest.cs	Adds regression tests validating ToString(...) behavior in code blocks.
src/Engine/ProtoCore/Lang/BuiltInMethods.cs	Introduces MethodID.ToString, maps it to "ToString", and registers the built-in signature.
src/Engine/ProtoCore/Lang/BuiltInFunctionEndPoint.cs	Dispatches MethodID.ToString to the existing string conversion implementation.

[Copilot]

Test name says "ThenNoWarning" but the test only asserts the computed string. To make the regression explicit (and avoid the test passing while still emitting a runtime warning), also assert that the runtime warning count is 0 (or rename the test to match what it verifies).

Suggested change

	thisTest.Verify("result", "1.000000,2.000000");
	thisTest.Verify("result", "1.000000,2.000000");
	Assert.AreEqual(0, core.RuntimeStatus.WarningCount);

[ivaylo-matov]

@zeusongit, yes this makes sense - ToString wasn't properly registered for scalar values. We’re noticing it now because Dynamo is doing a bit more work to inspect the code inside the CBN.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jasonstratton]

LGTM

[jasonstratton]

Re-Running:
SelfServ #215 - https://c007.cloudbees-ci.autodesk.com/job/DYNCI/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/215/
Smoke Test: 196 - https://c007.cloudbees-ci.autodesk.com/job/DYNCI/job/Dynamo/job/DynamoAGTTests/job/smoke/196/

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud