Skip to content

Modernize DynamoModel.cs to C# 12 idioms - #16880

Draft
QilongTang with Copilot wants to merge 4 commits into
masterfrom
copilot/clean-up-dynamomodel-cs
Draft

Modernize DynamoModel.cs to C# 12 idioms#16880
QilongTang with Copilot wants to merge 4 commits into
masterfrom
copilot/clean-up-dynamomodel-cs

Replace string concatenation with interpolation in DynamoModel.cs

17fcbe4
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed Feb 7, 2026 in 2s

5 new alerts including 5 high severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 5 high

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 198 in src/DynamoCore/Logging/DynamoLogger.cs

See this annotation in the file changed.

Code scanning / CodeQL

Clear text storage of sensitive information High

This stores sensitive data returned by
access to local variable trustedLoc : String
Loading
as clear text.
This stores sensitive data returned by access to local variable trustedLoc : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedTempPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedTempPath : String as clear text.
This stores sensitive data returned by access to local variable trustedDirName : String as clear text.
This stores sensitive data returned by access to local variable trustedFileName : String as clear text.
This stores sensitive data returned by call to method SelectSingleNode : XmlNode as clear text.
This stores sensitive data returned by call to method DeserializeTrustedLocations : List as clear text.
This stores sensitive data returned by call to method DeserializeTrustedLocations : List as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method Combine : String as clear text.
This stores sensitive data returned by access to field trustedDir : String as clear text.
This stores sensitive data returned by access to field trustedDir : String as clear text.

Check failure on line 243 in src/DynamoCore/Logging/DynamoLogger.cs

See this annotation in the file changed.

Code scanning / CodeQL

Clear text storage of sensitive information High

This stores sensitive data returned by
access to local variable trustedLoc : String
Loading
as clear text.
This stores sensitive data returned by access to local variable trustedLoc : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedTempPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedTempPath : String as clear text.
This stores sensitive data returned by access to local variable trustedDirName : String as clear text.
This stores sensitive data returned by access to local variable trustedFileName : String as clear text.
This stores sensitive data returned by call to method SelectSingleNode : XmlNode as clear text.
This stores sensitive data returned by call to method DeserializeTrustedLocations : List as clear text.
This stores sensitive data returned by call to method DeserializeTrustedLocations : List as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method Combine : String as clear text.
This stores sensitive data returned by access to field trustedDir : String as clear text.
This stores sensitive data returned by access to field trustedDir : String as clear text.

Check failure on line 260 in src/DynamoCore/Logging/DynamoLogger.cs

See this annotation in the file changed.

Code scanning / CodeQL

Clear text storage of sensitive information High

This stores sensitive data returned by
access to local variable trustedLoc : String
Loading
as clear text.
This stores sensitive data returned by access to local variable trustedLoc : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedTempPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedTempPath : String as clear text.
This stores sensitive data returned by access to local variable trustedDirName : String as clear text.
This stores sensitive data returned by access to local variable trustedFileName : String as clear text.
This stores sensitive data returned by call to method SelectSingleNode : XmlNode as clear text.
This stores sensitive data returned by call to method DeserializeTrustedLocations : List as clear text.
This stores sensitive data returned by call to method DeserializeTrustedLocations : List as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method Combine : String as clear text.
This stores sensitive data returned by access to field trustedDir : String as clear text.
This stores sensitive data returned by access to field trustedDir : String as clear text.

Check failure on line 373 in src/DynamoCore/Logging/DynamoLogger.cs

See this annotation in the file changed.

Code scanning / CodeQL

Clear text storage of sensitive information High

This stores sensitive data returned by
access to local variable trustedLoc : String
Loading
as clear text.
This stores sensitive data returned by access to local variable trustedLoc : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedTempPath : String as clear text.
This stores sensitive data returned by access to local variable untrustedTempPath : String as clear text.
This stores sensitive data returned by access to local variable trustedDirName : String as clear text.
This stores sensitive data returned by access to local variable trustedFileName : String as clear text.
This stores sensitive data returned by call to method SelectSingleNode : XmlNode as clear text.
This stores sensitive data returned by call to method DeserializeTrustedLocations : List as clear text.
This stores sensitive data returned by call to method DeserializeTrustedLocations : List as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method CopyDynToUntrustedTemp : String as clear text.
This stores sensitive data returned by call to method Combine : String as clear text.
This stores sensitive data returned by access to field trustedDir : String as clear text.
This stores sensitive data returned by access to field trustedDir : String as clear text.

Check failure on line 1043 in src/DynamoCore/Models/DynamoModel.cs

See this annotation in the file changed.

Code scanning / CodeQL

Clear text storage of sensitive information High

This stores sensitive data returned by
call to method SelectSingleNode : XmlNode
Loading
as clear text.
This stores sensitive data returned by
call to method DeserializeTrustedLocations : List
Loading
as clear text.
This stores sensitive data returned by
access to local variable trustedLoc : String
Loading
as clear text.
This stores sensitive data returned by
access to local variable trustedLoc : String
Loading
as clear text.