Measure cell planar residual on cutter CL, not contact points - #20
Merged
Conversation
Valley cells between humps looked non-planar in the lattice but scored in tolerance because contact_point residual stayed flat. Add a separate planar tol control and a headless regression for the CL vs contact case. Assisted-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node.p) vs avg contact-normal plane — notcontact_point(Julian CNC 162: valley cells between humps looked warped but scored in tolerance).tools/test_planar_residual.gd+ CI step.Test plan
Assisted-by: Cursor