Skip to content

Translation Files Json key sorting - #1431

Open
unabomberlive wants to merge 1 commit into
DuarteSantos8:mainfrom
unabomberlive:main
Open

unabomberlive wants to merge 1 commit into
DuarteSantos8:mainfrom
unabomberlive:main

Conversation

@unabomberlive

@unabomberlive unabomberlive commented Nov 21, 2026 •

Copy link
Copy Markdown

I sorted the exercise number keys in the range [0001 – 12018] for greater consistency during translation.

What and why

I think this adds logic for translators - no need to jump around the file via search, and the structure of the translated files matches the arrangement of the original file names (in alphabetical order).

Where did you try it?

  • Web app (browser / home-screen PWA)
  • iPhone app (simulator, your own device, or TestFlight)
  • Apple Watch app
  • Android app (APK or emulator)
  • Self-hosted server (docker compose)
  • Only tests, no UI change

Checklist

  • Tests added or updated (cd frontend && npm test, cd api && npm test)
  • New UI text goes through t() and is in every locale pack (node scripts/check-locales.mjs)
  • Screenshots or a short clip for UI changes (no exercise animations in them, please)
  • I signed the CLA (the bot asks on your first PR)

Summary by CodeRabbit

  • Catalogue Updates
    • Exercise entries in the Danish, Portuguese, and Swedish catalogues are now arranged in numeric ID order. Existing entries and translations remain unchanged.

I sorted the exercise number keys in the range [0001 – 12018] for greater consistency during translation.
@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA. Thank you!
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Explain Change →

Walkthrough

The Danish, Portuguese, and Swedish exercise catalogues are reordered by numeric ID. Their existing keys and translation values are retained.

Changes: Catalogue ordering

Layer / File(s) Summary
Reorder catalogue entries by numeric ID
catalogue/i18n/da.json, catalogue/i18n/pt.json, catalogue/i18n/sv.json
The three catalogues place entries in numeric ID order. Existing keys and translation values are retained.

Estimated code review effort: 2 (Simple) | ~10 minutes

Architecture risk: Low · up to 8a1dd

The change affects 1 system.

Changed systems: catalogue

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — catalogue (service) was modified; 3 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in catalogue/i18n/da.json: The catalogue entries are reordered by numeric key; the existing keys and Danish exercise-name values are retained.
  • observed — Modified behavior in catalogue/i18n/pt.json: Entries 1001–1006 are grouped in numeric order instead of being interleaved with higher-numbered keys.
  • observed — Modified behavior in catalogue/i18n/pt.json: Entries 1010–1013 are grouped in numeric order; their translation values are unchanged.
  • observed — Modified behavior in catalogue/i18n/pt.json: Entries 1017, 1018, and 1020 are placed together in numeric order with unchanged translations.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: sorting the exercise number keys in the translation JSON files. It is specific and matches the summaries for da.json, pt.json, and sv.json. Minor issue: it is a bit te…
Description check Passed The description states the purpose (sorting exercise keys in the range 0001 to 12018 for translator consistency) and explains why in the 'What and why' section. It does not include an issue link, and …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: sorting the exercise number keys in the translation JSON files. It is specific and matches the summaries for da.json, pt.json, and sv.json. Minor issue: it is a bit terse and the casing is inconsistent ("Json"), but it is clear enough for history scanning.

Full details: Description check

Explanation

The description states the purpose (sorting exercise keys in the range 0001 to 12018 for translator consistency) and explains why in the 'What and why' section. It does not include an issue link, and every test, platform, and checklist item is unchecked. The template's checklist items about tests, the t() and check-locales script, and the CLA are not addressed. The PR changes only JSON data, so most checkboxes may not apply, but the author should state that explicitly. The template's 'Where did you try it?' section is left blank, and the description leaves the template's own comment in place.

Resolution

Optional improvements: mark 'Only tests, no UI change' (or state that no UI text changed) and confirm the locale check ran, since the change touches translation files. Also state whether the CLA was signed, and remove the template comment if it is no longer needed.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
Fix failing CI checks

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Review coverage is incomplete: 19 files could not be fully reviewed. Findings from completed review steps are included; see review info for details.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e4a68a9 and 8a1dd16.

Files selected for processing: 22

  • catalogue/i18n/ar.json
  • catalogue/i18n/bn.json
  • catalogue/i18n/cs.json
  • catalogue/i18n/da.json
  • catalogue/i18n/de.json
  • catalogue/i18n/es.json
  • catalogue/i18n/fa.json
  • catalogue/i18n/fr.json
  • catalogue/i18n/hi.json
  • catalogue/i18n/hu.json
  • catalogue/i18n/it.json
  • catalogue/i18n/ko.json
  • catalogue/i18n/pl.json
  • catalogue/i18n/pt-BR.json
  • catalogue/i18n/pt.json
  • catalogue/i18n/ru.json
  • catalogue/i18n/sv.json
  • catalogue/i18n/th.json
  • catalogue/i18n/tr.json
  • catalogue/i18n/uk.json
  • catalogue/i18n/zh-TW.json
  • catalogue/i18n/zh.json
Files not fully reviewed because they exceed a per-file size limit: 19

  • catalogue/i18n/bn.json
  • catalogue/i18n/fr.json
  • catalogue/i18n/de.json
  • catalogue/i18n/ar.json
  • catalogue/i18n/es.json
  • catalogue/i18n/fa.json
  • catalogue/i18n/cs.json
  • catalogue/i18n/hu.json
  • catalogue/i18n/ko.json
  • catalogue/i18n/hi.json
  • catalogue/i18n/pt-BR.json
  • catalogue/i18n/pl.json
  • catalogue/i18n/ru.json
  • catalogue/i18n/it.json
  • catalogue/i18n/th.json
  • catalogue/i18n/tr.json
  • catalogue/i18n/zh-TW.json
  • catalogue/i18n/uk.json
  • catalogue/i18n/zh.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@unabomberlive

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Nov 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant