Skip to content

Watches (German): Skip on the rest reads "Weiter", not "Überspringen" - #1401

Open
cubetes wants to merge 1 commit into
DuarteSantos8:release-1.4.6from
cubetes:fix/watch-de-skip
Open

cubetes wants to merge 1 commit into
DuarteSantos8:release-1.4.6from
cubetes:fix/watch-de-skip

Conversation

@cubetes

@cubetes cubetes commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Suggested labels: bug, mobile

Mid-rest you glance at the watch and want one clear word to tap. In German that word was "Überspringen": too long for the small button between −15 and +15, so it looked cramped, and on a 40 mm watch it fell back to a bare symbol. Now it reads "Weiter", the word the owner picked from mips6904's suggestions on Discord.

What changes

  • frontend/ios/ci/watch-strings.mjs: a small SHORTER map gives the watch its own word where the app's is too long for a watch button. Only one entry: 'Skip': { de: 'Weiter' }. Every other language still takes the app's word.
  • Regenerated Watch/de.lproj and WatchWidgets/de.lproj: "Skip" = "Weiter".
  • Wear OS: wear-strings.mjs now takes skip from the Apple Watch's strings instead of the app pack, so the Wear rest button says "Weiter" too. Only values-de/strings.xml changes; every other language's word was already the same on both sides.
  • The phone keeps "Überspringen" (tour, coach intake, rest timer), where it has room.

"Weiter" is not used for any other button on either watch ("Continue workout" is "Weitertrainieren", "Keep going" is "Weitermachen", Next set is only a VoiceOver label), so no two buttons read the same.

How it was tested

  • Ran both generators; the only generated changes are the German Skip lines (an older, unrelated pt-BR Wear drift was left out).
  • node scripts/check-locales.mjs and node scripts/check-source-strings.mjs --strict: in sync.
  • npx vitest run src/lib/watch-catalog.test.js src/lib/watch-sync.wear.test.js src/lib/voice-strings.test.js: 15 passed.
  • Not checked on a wrist; no layout code changed.

Closes #1400

Related: #1071 (open) adds a phone sentence that names the watch's rest button "Überspringen"; if both land, that sentence should say "Weiter". #1139 and #1319 change RestHold.swift layout, not the word.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LXHs9Pg1EhvFPo2LUFWwrp

Summary by CodeRabbit

  • Localization
    • Updated the German “Skip” label to “Weiter” on Android and Apple Watch.
    • Added a German watch-specific translation, with the app translation used when no override is available.

…DuarteSantos8#1400)

The watch generator takes a shorter watch-only word where the app's does not fit its buttons;
Wear OS takes Skip from the Apple Watch's strings, so both watches say the same. The phone
keeps "Überspringen".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LXHs9Pg1EhvFPo2LUFWwrp
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The iOS watch-string generator now supports language-specific overrides, with German “Weiter” for “Skip”. Wear OS now sources skip from watch strings, and its German translation changes to “Weiter”.

Changes: German watch Skip label

Layer / File(s) Summary
iOS watch localization
frontend/ios/ci/watch-strings.mjs
The generator uses a language-specific override when available. The German override for “Skip” is “Weiter”.
Wear OS localization
frontend/android/wear/wear-strings.mjs, frontend/android/wear/src/main/res/values-de/strings.xml
Wear OS now sources skip from watch strings. Its German translation changes from “Überspringen” to “Weiter”.

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Low

Merge Risk: Minimal · up to 72a98

German watch users will see the shorter "Weiter" on the rest-screen Skip button, and the phone keeps "Überspringen". No concrete merge-blocking risk was found.

Security architecture risk: Minimal · up to 72a98

The change shortens the German watch label and reuses existing localization machinery. No introduced or worsened security, failure-containment, rollback, or ownership risk was identified in the inspected changes.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change (German Skip label on the watch reads "Weiter" instead of "Überspringen"), which matches the main change in the changeset. It is specific, one sentence, and avoids vague ter…
Description check Passed The description explains the problem ("Überspringen" is too long for the watch button), the fix ("Weiter"), and the scope (Apple Watch and Wear OS, phone unchanged). It lists changed files, testing do…
Linked Issues check Passed [#1400] The issue requires a short German Skip label on the Apple Watch rest screen, with "Weiter" chosen by the owner, and a matching fix for the Wear OS rest button. The PR meets both parts in sourc…
Out of Scope Changes check Passed All changes map to #1400. The change set has three source files: watch-strings.mjs (new SHORTER override), wear-strings.mjs (skip source moved to Apple Watch strings), and values-de/strings.xml …
Full details: Title check

Explanation

The title names the change (German Skip label on the watch reads "Weiter" instead of "Überspringen"), which matches the main change in the changeset. It is specific, one sentence, and avoids vague terms. Its length (69 characters) is acceptable.

Full details: Description check

Explanation

The description explains the problem ("Überspringen" is too long for the watch button), the fix ("Weiter"), and the scope (Apple Watch and Wear OS, phone unchanged). It lists changed files, testing done, and links issue #1400. It does not follow the repository template's sections exactly: the 'Where did you try it?' platform checklist and the 'Checklist' section (CLA, screenshots, tests via npm test, check-locales note) are missing or not ticked. The 'What and why' section is present in substance, and 'Closes #1400' links the issue.

Resolution

Optionally add the template's 'Where did you try it?' selections (Apple Watch app and Android app) and complete the Checklist section, including the screenshot or clip note for UI-visible changes, and the CLA confirmation.

Full details: Linked Issues check

Explanation

[#1400] The issue requires a short German Skip label on the Apple Watch rest screen, with "Weiter" chosen by the owner, and a matching fix for the Wear OS rest button. The PR meets both parts in source code. (1) frontend/ios/ci/watch-strings.mjs adds a SHORTER map with 'Skip': { de: 'Weiter' }. The generator uses this override before the app word, so the watch German Skip string becomes "Weiter". (2) frontend/android/wear/wear-strings.mjs takes skip from the Apple Watch strings instead of the app pack. values-de/strings.xml changes skip from "Überspringen" to "Weiter". The phone keeps "Überspringen", as the issue asks. The clash requirement is met on the evidence in the PR description and issue: no other watch button uses "Weiter". Limit: the generated frontend/ios/App/Watch/de.lproj/Localizable.strings and frontend/ios/App/WatchWidgets/de.lproj/Localizable.strings files match the ignored_files rule !frontend/ios/App/**/*.lproj/Localizable.strings. Their content was not inspected. The generator change is independent reviewable evidence for the result. No automated test asserts the new SHORTER override directly; the existing generator and locale checks cover sync only.

Full details: Out of Scope Changes check

Explanation

All changes map to #1400. The change set has three source files: watch-strings.mjs (new SHORTER override), wear-strings.mjs (skip source moved to Apple Watch strings), and values-de/strings.xml (one German string). The regenerated iOS de.lproj files are generated output of the watch-strings change. They are excluded from review by ignored_files, so their content was not checked. The PR describes no other behavior change. Other languages keep their existing words. No layout code changed. The phone app string is unchanged, as the issue requires. The PR description says an unrelated pt-BR Wear drift was left out, so the change set does not include it.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between da62470 and 72a9840.

Files ignored due to path filters: 2

  • frontend/ios/App/Watch/de.lproj/Localizable.strings is excluded by !frontend/ios/App/**/*.lproj/Localizable.strings
  • frontend/ios/App/WatchWidgets/de.lproj/Localizable.strings is excluded by !frontend/ios/App/**/*.lproj/Localizable.strings
Files selected for processing: 3

  • frontend/android/wear/src/main/res/values-de/strings.xml
  • frontend/android/wear/wear-strings.mjs
  • frontend/ios/ci/watch-strings.mjs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant