Follow up of #689 - providing spool weight deltas as part of new payload_extras attribute in Spool Event#902
Open
chof747 wants to merge 10 commits intoDonkie:masterfrom
Open
Follow up of #689 - providing spool weight deltas as part of new payload_extras attribute in Spool Event#902chof747 wants to merge 10 commits intoDonkie:masterfrom
chof747 wants to merge 10 commits intoDonkie:masterfrom
Conversation
The actual consumption of the spool is stored in the extra part of the spool object under event_delta and can be use to track relative changes in the consumption.
resyncing master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is following up on @Donkie's comments on my previous pull request 689 to provide the delta in weight on a spool update not in the payload of the SpoolEvent but as an attribute in an additional
payload_extraentry of the event data.It follows the recommendations and added also a test case to the integration tests to confirm the correct event propagation with the correct data in test_spool_event.py.