fix(custom-fields): align #773 filter/sort with current master#858
Closed
akira69 wants to merge 5 commits intoDonkie:masterfrom
Closed
fix(custom-fields): align #773 filter/sort with current master#858akira69 wants to merge 5 commits intoDonkie:masterfrom
akira69 wants to merge 5 commits intoDonkie:masterfrom
Conversation
11 tasks
8cf7854 to
d3877c9
Compare
12 tasks
09b01a7 to
2f46cab
Compare
93f167e to
4265d5a
Compare
This was referenced Feb 23, 2026
Open
Open
5327ceb to
31dccf7
Compare
akira69
added a commit
to akira69/Spoolman_Labels
that referenced
this pull request
Feb 24, 2026
31dccf7 to
004851e
Compare
16 tasks
akira69
added a commit
to akira69/Spoolman_Labels
that referenced
this pull request
Feb 24, 2026
004851e to
7f5e300
Compare
12 tasks
akira69
added a commit
to akira69/Spoolman_Labels
that referenced
this pull request
Feb 24, 2026
7f5e300 to
2e1e738
Compare
7 tasks
This was referenced Feb 24, 2026
2e1e738 to
1908c55
Compare
9 tasks
1908c55 to
31830b0
Compare
31830b0 to
f70d801
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is intended as the small add-on / current-master alignment layer for upstream PR #773.
Conceptually:
#773is the main custom-field filter/sort feature#858is the follow-up needed to keep that work aligned with currentmasterImportant Branch Note
Although the intended scope here is the follow-up layer, this branch currently still contains the inherited
#773custom-field commits as its base.So reviewers should read the scope like this:
#773If the
#773work is updated directly, this PR may no longer need to exist separately.What #773 Covers
The primary custom-field feature set comes from
#773, including:What #858 Adds
The follow-up work here is the current-master alignment layer:
f70d801fix(ts): align custom-field filter/sort typings with current masterIn practice, this fixes the frontend/state-mapping edge so custom-field sort and filter state stays attached to the correct dynamic column when
dataIndexis array-based.Files directly relevant to that add-on:
client/src/components/column.tsxclient/src/utils/sorting.tsScope Boundary
This PR is only about custom/extra-field filter and sort behavior.
It does not include the broader searchable filter UX for standard columns. That work remains separate in
#862.So:
#858= custom-field / extra-field filter-sort behavior and alignment#862= broader filter-dropdown UX improvements for normal columnsValidation
docker run --rm -v "$PWD:/app" -w /app/client -e VITE_APIURL=/api/v1 -e NPM_CONFIG_CACHE=/tmp/.npm -e XDG_CONFIG_HOME=/tmp/.config -e HOME=/tmp node:20 /bin/bash -lc "npm ci && npm run build"#773custom-field stack:tests_integration/tests/fields/test_filter_sort.pyOut of Scope
The following remain separate:
#861)#862)#863)#864)#865)#866)#867)#868)Merge Coordination
#773remains the primary feature reference for this area.#858should be treated as the follow-up alignment layer for that work, even though the branch still contains the inherited#773commits.#773is updated directly, the cleanest outcome may be to fold thef70d801follow-up into that branch and close#858.#862and#865do not duplicate this feature, but they touch adjacent API/database plumbing and may need a small rebase.Shared touchpoints with
#862/#865:spoolman/api/v1/filament.pyspoolman/database/filament.pyAdditional shared touchpoints with
#862:spoolman/api/v1/spool.pyspoolman/database/spool.pyclient/src/components/column.tsxExpected conflict scope is shared function signatures and adjacent logic, not duplicate feature behavior.