Repository navigation
fix(mounts): write file mounts as files on create - #5791
Merged
Merged
Conversation
imrja8
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Two bugs when creating a file mount:
filePath(possible via the API), the content was written over the service's wholefiles/directory. It's now rejected.updateFileMountalready does.Checklist
canarybranch.Issues related (if applicable)
closes #5292


Confidence Score: 5/5
This PR appears safe to merge; no new actionable issues were found.Summary
This PR rejects missing or unsafe file paths and replaces empty directories Docker created with files.
Reviews (3) · Last reviewed commit: "fix(mounts): validate file paths on upda..." · Reviewed by Greptile