Repository navigation
fix(mounts): show the file on disk in the File Mount editor - #5782
Merged
Merged
Conversation
narcisonunez
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
The File Mount editor only showed the content stored in Dokploy's database. When an app writes to its own bind-mounted file (e.g. AnythingLLM saving settings to
.env), the change reaches the file on disk but never shows up in the editor, and clicking Update writes the stale copy back over it.The editor now reads the file from disk when it opens (locally, or over SSH for remote servers) and falls back to the stored content if the file is missing or can't be read. The read never follows symlinks or paths outside the service's
files/directory.To reproduce: create a Compose service with a File Mount
app.env(FOO=from-dokploy) mounted as../files/app.env:/data/app.env, deploy, then rundocker exec <container> sh -c 'printf "\nBAR=from-app\n" >> /data/app.env'.FOO=from-dokploy, and Update deletesBAR.Checklist
canarybranch.Issues related (if applicable)
closes #5678
Screenshots (if applicable)
Tested it and manually verified.


Confidence Score: 5/5
The changes appear safe to merge; no new actionable issue was established.Summary
The File Mount editor now reads the file on disk instead of showing only the stored copy.
Both earlier threads were unnumbered, so neither receives a
previousFindingsentry. The current code addresses their reported paths: it checks the opened file rather than only the final path component, and disables editing and saving while the read runs.Reviews (2) · Last reviewed commit: "fix(mounts): confine file reads, wait fo..." · Reviewed by Greptile