Repository navigation
Conversation
The search procedures of application, compose, postgres, mysql, mariadb, mongo and redis always filtered results by the caller's accessedServices. A service only lands in that list for the member who created it, so owners and admins missed services created by others and got nothing when their list was empty. Apply the filter only to members, as checkServiceAccess and project.one already do. Closes Dokploy#5361 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+72
to
+73
| const whereParams = () => | ||
| new PgDialect().sqlToQuery(whereClauses[0] as SQL).params; |
Contributor
There was a problem hiding this comment.
whereParams() checks only the items query. The count query is never checked, and its mock always returns 1, so these tests would still pass if that query lost the organization or member filter. Assert that both recorded clauses contain the expected parameters.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
The
searchprocedures of the application, compose, postgres, mysql, mariadb, mongo and redis routers always limited results to the caller'saccessedServices. A service is only added to that list for the member who created it, so:*.oneand the dashboard show them;accessedServiceslist gets{ items: [], total: 0 }from every search.The filter now applies only to members, the same way
checkServiceAccessandproject.oneexempt theownerandadminroles. For members the behaviour is unchanged.Added
apps/dokploy/__test__/permissions/search-service-access.test.ts, which callssearchon each of the seven routers and checks that:The owner and admin cases fail on
canarywithout this change.Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #5361
🤖 Generated with Claude Code
The PR appears safe to merge, with a non-blocking improvement to the count-query tests.
Summary
Updates seven service searches so owners and admins can find all services in their active organization.
Reviews (1) · Last reviewed commit: "fix(search): return all services to owne..." · Reviewed by Greptile