Repository navigation
fix(cluster): load saved replicas and registry in cluster settings - #5778
Merged
Merged
Conversation
imrja8
approved these changes
Oct 25, 2026
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
The Cluster Settings form (replicas, registry) only reset from loaded data when the service had a custom
command, so switching services kept showing the previous service's values, and saving wrote them to the new one. It now resets whenever the data changes, and the registry select is controlled. Applies to applications and databases.Checklist
canarybranch.Issues related (if applicable)
Related to #5193


Confidence Score: 5/5
The PR appears safe to merge.Summary
The cluster form loads saved replicas and registry values without requiring a custom command.
Reviews (2) · Last reviewed commit: "fix(cluster): don't reset cluster settin..." · Reviewed by Greptile