Skip to content

fix(environment): keep saved env in the editor after save - #5777

Merged
narcisonunez merged 1 commit into
canaryfrom
fix/5277-env-editor-stale-poll
Oct 26, 2026
Merged

narcisonunez merged 1 commit into
canaryfrom
fix/5277-env-editor-stale-poll

Conversation

@narcisonunez

@narcisonunez narcisonunez commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

What is this PR about?

After saving, form.reset clears isDirty and the reset effect re-applies the pre-save cached application.one value, so the editor reverts and the caret jumps to line 1 until the refetch lands. Saving again from that state writes the old value back. The cache is now updated with the saved values before the reset.

Checklist

Issues related (if applicable)

closes #5277

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Updates the cached application.one values after a successful environment save, before resetting the form.

  • The environment editor keeps saved settings visible while fresh data loads.

Reviews (1) · Last reviewed commit: "fix(environment): keep saved env in the ..." · Reviewed by Greptile

@narcisonunez
narcisonunez merged commit ab8cc42 into canary Oct 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Application environment editor reverts to stale value after a successful save

2 participants