Repository navigation
fix(environment): keep saved env in the editor after save - #5777
Merged
Merged
Conversation
imrja8
approved these changes
Oct 25, 2026
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
After saving,
form.resetclearsisDirtyand the reset effect re-applies the pre-save cachedapplication.onevalue, so the editor reverts and the caret jumps to line 1 until the refetch lands. Saving again from that state writes the old value back. The cache is now updated with the saved values before the reset.Checklist
canarybranch.Issues related (if applicable)
closes #5277


Confidence Score: 5/5
The PR appears safe to merge.Summary
Updates the cached
application.onevalues after a successful environment save, before resetting the form.Reviews (1) · Last reviewed commit: "fix(environment): keep saved env in the ..." · Reviewed by Greptile