Repository navigation
feat(notifications): add domain change notifications - #5766
Closed
tarikyalcinkaya wants to merge 2 commits into
Closed
tarikyalcinkaya wants to merge 2 commits into
tarikyalcinkaya wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Adds a "Domain Changes" notification event so external tools can react to the set of domains
Dokploy serves (uptime monitors, DNS automation, inventory). It follows the shape of the existing
notification types: a single
domainChangedflag, a sender for every provider, and a switch in"Select the actions."
imports and project duplication.
removedevent for each of its domains, sincethey are cascade-deleted there and that path would otherwise be silent.
customprovider gets a structured payload:event(created/updated/removed),domainId,host,url,https,path,port,enabled, plus project, service andenvironment names.
The generated migration also contains a
whitelabelingConfigdefault change; that comes fromdrift already on
canary(the schema default was changed without a migration), not from this PR.How I tested it
On a local instance (
pnpm dokploy:dev) with a custom notification pointed at a local listener:received
created,updated,updatedwithenabled: false, andremoved, each with theright URL (including https and path).
createdwithserviceType: compose.removedper domain.notification with the switch on still received the event.
pnpm test,pnpm typecheckandpnpm buildpass.Checklist
canarybranch.Issues related (if applicable)
closes #4938
Screenshots (if applicable)
Fix the broken notification-create inputs, request-blocking delivery, and missing lifecycle events before merging.
Summary
Adds opt-in domain-change notifications across the supported providers, including structured custom webhook payloads and a settings switch.
Acknowledged:
tarikyalcinkayastates that thewhitelabelingConfigdefault change comes from existing schema drift oncanary, not this feature.Reviews (1) · Last reviewed commit: "feat(notifications): add domain change n..." · Reviewed by Greptile