Skip to content

fix: security issues - #5752

Merged
narcisonunez merged 2 commits into
canaryfrom
fix/security-issues
Oct 22, 2026
Merged

narcisonunez merged 2 commits into
canaryfrom
fix/security-issues

Conversation

@narcisonunez

@narcisonunez narcisonunez commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

What is this PR about?

Bundles the fixes for four security issues:

Tested locally end to end: two organizations attacking each other's ids, destinations, certificates, a private relative submodule against a token-protected git server, and a failed deploy with an SSH key reaching a Slack-compatible listener. Not exercised locally: a real pg_dump to S3 and the interactive terminal (Docker Desktop swarm and node-pty limits).

Checklist

Issues related (if applicable)

closes #5635
closes #5618
closes #5557
closes #5541

Supersedes #5619 and #5717.

RetriggerView in GreptileConfidence Score: 5/5

The latest changes appear safe to merge; the server history access issue is fixed.

Summary

This PR tightens organization checks, checks backup destinations, confines certificate paths, moves Git tokens out of clone URLs, and uses build logs in failure notifications.

  • Service and project actions stay within the active organization.
  • Backup jobs use destinations owned by the backup's organization.
  • Git provider clones authenticate with a host-scoped header.
  • Build failure notices show the deployment log tail.
  • Certificate files stay inside the certificate directory.
  • Compose updates accept only valid provider branch names.

Reviews (2) · Last reviewed commit: "fix(deployment): restrict server deploym..." · Reviewed by Greptile

…ssues

- scope service permission checks to the active organization (#5635)
- check backup and volume backup destinations against the organization,
  confine certificate paths to CERTIFICATES_PATH, validate compose
  branches (#5541)
- send git provider tokens through an http extraHeader instead of the
  clone URL so submodule URLs and build logs never contain them (#5618)
- send the build log tail in build failure notifications (#5557)
@narcisonunez narcisonunez changed the title fix: security issues #5635, #5618, #5557, #5541 fix: security issues Oct 22, 2026
Comment thread apps/dokploy/server/api/routers/deployment.ts
Comment thread packages/server/src/db/schema/compose.ts
@narcisonunez
narcisonunez merged commit e255f69 into canary Oct 22, 2026
5 checks passed
AminDhouib added a commit to DevinoSolutions/dokploy-community that referenced this pull request Oct 23, 2026
fix(security): port upstream Dokploy#5752 (cross-tenant IDOR, backup destination org checks, cert path confinement, git token header, build-error log tail)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants