Repository navigation
fix: security issues - #5752
Merged
Merged
fix: security issues#5752
Conversation
…ssues - scope service permission checks to the active organization (#5635) - check backup and volume backup destinations against the organization, confine certificate paths to CERTIFICATES_PATH, validate compose branches (#5541) - send git provider tokens through an http extraHeader instead of the clone URL so submodule URLs and build logs never contain them (#5618) - send the build log tail in build failure notifications (#5557)
imrja8
approved these changes
Oct 22, 2026
AminDhouib
added a commit
to DevinoSolutions/dokploy-community
that referenced
this pull request
Oct 23, 2026
fix(security): port upstream Dokploy#5752 (cross-tenant IDOR, backup destination org checks, cert path confinement, git token header, build-error log tail)
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Bundles the fixes for four security issues:
checkServiceAccess,checkServicePermissionAndAccessandcheckEnvironmentCreationPermissionnow require the target service/project to belong to the active organization for every role.deployment.allByTyperesolves the owning service for backup, volume backup and preview deployment ids so those modals keep working.certificatePathis no longer accepted from the client and the certificate directory is confined toCERTIFICATES_PATH. Compose branch fields use the existing branch validator. Service-lessweb-serverbackups stay unscoped.http.<origin>/.extraHeaderinstead of the clone URL (GitHub, GitLab, Gitea). Based on fix: keep git provider tokens out of clone URLs #5619 by @Souvik-Cyclic.error.message. Based on fix(notifications): send the build log tail, not the build script, on build failure #5717 by @Gourav224. The key leak itself was already closed by fix: stop leaking secrets through ExecError and bind container terminal to its service #5733.Tested locally end to end: two organizations attacking each other's ids, destinations, certificates, a private relative submodule against a token-protected git server, and a failed deploy with an SSH key reaching a Slack-compatible listener. Not exercised locally: a real
pg_dumpto S3 and the interactive terminal (Docker Desktop swarm and node-pty limits).Checklist
canarybranch.Issues related (if applicable)
closes #5635
closes #5618
closes #5557
closes #5541
Supersedes #5619 and #5717.


Confidence Score: 5/5
The latest changes appear safe to merge; the server history access issue is fixed.Summary
This PR tightens organization checks, checks backup destinations, confines certificate paths, moves Git tokens out of clone URLs, and uses build logs in failure notifications.
Reviews (2) · Last reviewed commit: "fix(deployment): restrict server deploym..." · Reviewed by Greptile