Added dedicated GIF post view with controls#1126
Added dedicated GIF post view with controls#1126Neywiny wants to merge 4 commits intoDocile-Alligator:masterfrom
Conversation
app/build.gradle
Outdated
| } | ||
|
|
||
| android { | ||
| compileSdk 32 |
There was a problem hiding this comment.
That's likely because my phone is old and I was trying to get some things to line up with the debugger. I guess it should be changed back.
| void inject(AccountSavedThingActivity accountSavedThingActivity); | ||
|
|
||
| void inject(ViewImageOrGifActivity viewGIFActivity); | ||
| void inject(ViewImageActivity viewGIFActivity); |
There was a problem hiding this comment.
Should be viewImageActivity
| void inject(ViewImageOrGifActivity viewGIFActivity); | ||
| void inject(ViewImageActivity viewGIFActivity); | ||
|
|
||
| void inject(ViewGifActivity viewGIFActivity); |
There was a problem hiding this comment.
Should be viewGifActivity
app/build.gradle
Outdated
| def butterknifeVersion = "10.2.3" | ||
| implementation "com.jakewharton:butterknife:$butterknifeVersion" | ||
| annotationProcessor "com.jakewharton:butterknife-compiler:$butterknifeVersion" | ||
| compileOnly 'com.android.databinding:viewbinding:7.3.0' |
app/build.gradle
Outdated
| } | ||
|
|
||
| buildFeatures { | ||
| viewBinding true |
| shrinkResources true | ||
| proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro' | ||
| } | ||
| debug { |
There was a problem hiding this comment.
This should not be removed.
|
Please merge the newest changes first. |
Neywiny
force-pushed
the
dedicated-gif-post-view
branch
from
3e1e3ca to
719004e
Compare
…Infinity-For-Reddit into dedicated-gif-post-view
|
Well I've been trying to find out how to do this for maybe 5 hours now. I really just want a few files changed. I don't know how to get git to just have the few files change on my dev branch. It keeps replacing files with old versions. I only need to change like a few files to get this done. I think if this one doesn't go through, I'll just give up on it. |
|
Hey @Neywiny Sorry for the late reply. First of all never give up 😉. I think your solution would be to just use git merge and solve the merge conflicts by hand. The first steps into the open source world are normally very difficult, but once you get the the heck out of it, the gate opens up. Would be glad to see you again in our project. |
|
@Neywiny, if this change is still relevant, I can help you to rebase the branch. |
4 participants
Premise:
I found myself wanting to pause GIFs or restart them. So, I looked into what options there were and saw that there was already a gif package that Infinity was using with a class that supported it. Never contributed to an open-source project like this, usually just making comments/issues. I really just want the feature implemented; I don't mind if the code is torn apart.
Implementation:
Originally was just going to replace the BigImageView, but in the interest of preserving full image functionality (such as zoom/pan), I split the views. This has the added benefit of simplifying things like hiding buttons depending on if it's a GIF or not, and a lot of the supporting code if not all of it already had hooks to differentiate the two. So, I just pointed the rest of the code to the correct class. Cleans up GIF views when images aren't viewed and vice versa.
Other things:
I also made some changes Android Studio recommended, things like bumping versions and whatnot in the Gradle and redoing some deprecated code.
Where I have suspicions of my own wrongdoing:
My Java is rusty, and I was designing this to be only for my phone which is still on Android 8. So, I'm sure there's a lot to do to make it better. I also am unfamiliar with app development past some light messing around, so a lot of the packages and addons and things are unfamiliar to me. Things like @Inject and @BindView. I tried my best, but I probably got some things wrong.
I may have messed up some things in the manifest, I'm not sure.
Thank you