Skip to content

fix(build): improve handling of missing rustc args during workspace hotpatch replay #5615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rami3l wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(build): improve handling of missing rustc args during workspace hotpatch replay #5615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/cli/src/build/link.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,15 @@ impl BuildRequest {
let replayed_crates = self.workspace_hotpatch_replay_order(modified_crates)?;
tracing::debug!("replaying crates: {replayed_crates:?}");
for crate_name in &replayed_crates {
let rustc_args = self
.workspace_hotpatch_replay_args(workspace_rustc_args, crate_name)
.with_context(|| format!("Missing rustc args for replay: '{crate_name}'"))?;
self.compile_dep_crate(ctx, crate_name, rustc_args)
.await
.with_context(|| format!("Failed to replay workspace crate '{crate_name}'"))?;
if let Some(rustc_args) =
self.workspace_hotpatch_replay_args(workspace_rustc_args, crate_name)
{
self.compile_dep_crate(ctx, crate_name, rustc_args)
.await
.with_context(|| format!("Failed to replay workspace crate '{crate_name}'"))?;
} else {
tracing::warn!("No captured rustc args for workspace crate '{crate_name}', skipping");
}
}

// Recompile just the tip crate now
Expand Down