Add native commands supports to every modules#120
Open
Bricklou wants to merge 12 commits into
Open
Conversation
Equinox4
suggested changes
Jul 4, 2026
| table.remove(messagesToDelete[#messagesToDelete], #messagesToDelete[#messagesToDelete]) | ||
| -- Text command invocation posts a message right after the range we just fetched; strip it. | ||
| -- Context-menu invocations don't post one, so this must stay conditional. | ||
| if (trimInvokingMessage) then |
Contributor
There was a problem hiding this comment.
useless since "true" is hardcoded by caller
Author
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
I added comments on each call sites
Elanis
reviewed
Jul 4, 2026
Elanis
left a comment
Elanis
left a comment
Contributor
There was a problem hiding this comment.
What started out as a code review ended up turning into an english-focused review 😅
Bricklou
force-pushed
the
feature/commands-enhancement
branch
from
bcd34f4 to
a80865d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, NaB only support message commands. This PR is here to provide a support for a subset of common commands for a better user experience.