Ispyb integration vmxm grid scan#1653
Merged
Merged
Conversation
olliesilvester
force-pushed
the
ispyb_integration_vmxm_grid_scan
branch
from
44e7612 to
2a3e3f2
Compare
rtuck99
reviewed
May 13, 2026
|
|
||
| # We should improve slit PV name to give consistency, or come up with a way | ||
| # to get better typing on the _data dict | ||
| if _data["s4_slit_gaps-xgap"]: |
Contributor
There was a problem hiding this comment.
There is already an mx-bluesky issue to end this madness:
- Change s4 slits to use common slits #1555
and also a dodal issue - Rationalise Slits Implementations dodal#462
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ispyb integration for vmxm grid scans
Requires
Also requires additional changes from beamline hotfixes
Instructions to reviewer on how to test:
Checks for reviewer