Skip to content

Added i15-1 zebra shutter#2053

Open
DominicOram wants to merge 2 commits into
mainfrom
cryst_bluesky_10_fast_shutter
Open

Added i15-1 zebra shutter#2053
DominicOram wants to merge 2 commits into
mainfrom
cryst_bluesky_10_fast_shutter

Conversation

@DominicOram
Copy link
Copy Markdown
Contributor

@DominicOram DominicOram commented May 11, 2026

Fixes DiamondLightSource/crystallography-bluesky#10

Note, also needs DiamondLightSource/mx-bluesky#1742

Instructions to reviewer on how to test:

  1. Confirm tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (a832c86) to head (3a2fbb9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2053   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         327      327           
  Lines       12812    12837   +25     
=======================================
+ Hits        12699    12724   +25     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram DominicOram marked this pull request as ready for review May 11, 2026 13:33
@DominicOram DominicOram requested a review from a team as a code owner May 11, 2026 13:33
Copy link
Copy Markdown
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i15-1: Add implementation for fast shutter

2 participants