Adds photon mass attenuation calculations#2048
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 336 337 +1
Lines 13074 13079 +5
=======================================
+ Hits 12961 12966 +5
Misses 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CoePaul
reviewed
May 5, 2026
… how best to split functions - will be done next time
…n_depth_attenuation
…iamondLightSource/dodal into 2041_interconversion_depth_attenuation
…/dodal into 2039_photon_mass_calc
CoePaul
previously requested changes
May 13, 2026
Contributor
|
Got attracted to this issue seeing photon mass calculations!!! and got disappointed it is photon mass attenuation, May want to add attenuation to the pr title. As far as I know photon is massless at least at rest, E = m^2C^4+p^2c^2 and photon mass is refer to the m here which zero. |
Matt-Carre
changed the title
noemifrisina
approved these changes
May 14, 2026
Collaborator
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Looks okay, thanks - just one comment but take it or leave it
Also please rebase before merging
| "result", | ||
| [ | ||
| (5.042, 1.98e2, -2.717, 2.44170544), # Arbitrary Energy | ||
| (8.3328, 2.5706e3, -2.83, 6.3708311), # Arbitrary Nickel |
Collaborator
There was a problem hiding this comment.
Nit: the wording "arbitrary {element}" is extremely unclear.
…/dodal into 2039_photon_mass_calc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2039 - adds ability to calculate the photon mass attenuation per unit length, and tests this functionality.