Adds attenuation transmission interconversion calculations#2047
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2047 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 335 336 +1
Lines 13056 13074 +18
=======================================
+ Hits 12943 12961 +18
Misses 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CoePaul
previously requested changes
May 5, 2026
… how best to split functions - will be done next time
…n_depth_attenuation
noemifrisina
requested changes
May 6, 2026
Contributor
|
The standard for dodal for tests is "mirror the file structure of the src folder with the corresponding code files. Use the test_*.py naming convention for test files." Can you please update your tests accordingly? https://diamondlightsource.github.io/dodal/main/how-to/write-tests.html |
…htSource/dodal into 2040_attenuation_transmission
…n_depth_attenuation
…iamondLightSource/dodal into 2041_interconversion_depth_attenuation
…uation_transmission
…htSource/dodal into 2040_attenuation_transmission
noemifrisina
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2040
This adds calculations to convert between the:
attenuation and natural log of transmission and back,
transmission fraction and attenuation and back
Also includes tests for these functions.