Shader compiler options to save preprocessed and spirv, optimizer upgrade#1051
Open
Shader compiler options to save preprocessed and spirv, optimizer upgrade#1051
Conversation
Member
|
@AnastaZIuk this is your territory, bring this to completion |
AnastaZIuk
requested changes
Apr 16, 2026
… add new compiler option to shader cache entries
Contributor
Author
|
Done @AnastaZIuk |
AnastaZIuk
reviewed
Apr 17, 2026
Comment on lines
+569
to
+570
| m_system->deleteFile(filePath); | ||
| auto renameResult = m_system->moveFileOrDirectory(filePath + "_temp", filePath); |
Member
There was a problem hiding this comment.
this is risky because the temp file is still open here and rename can fail
ECF_SHARE_DELETE would make this more robust on windows but I would still rather drop saveFile before moveFileOrDirectory
saveFile = nullptr; // drop handle first
m_system->deleteFile(filePath); // safe to delete + rename
auto renameResult = m_system->moveFileOrDirectory(filePath + "_temp", filePath);we already do it for depfiles
Member
|
we also need to resolve conflicts, please pull master to nabla and examples |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives the shader compiler the option of outputting preprocessed and spirv files to a destination file, useful for debugging. Also when passing an optimizer give the option of replacing the default spirv-opt pass entirely (-O0 flag forwarded to DXC) OR to to run after the default optimization passes. Useful for stripping debug info without disabling optimization, for example.