Resampled Importance Sampling bxdfs#1027
Merged
devshgraphicsprogramming merged 39 commits intomasterfrom Apr 18, 2026
Merged
Conversation
devshgraphicsprogramming
changed the title
Comment on lines
+155
to
+205
| if (!system || outputPath.empty()) | ||
| return false; | ||
|
|
||
| const auto parent = outputPath.parent_path(); | ||
| if (!parent.empty() && !system->isDirectory(parent)) | ||
| { | ||
| if (!system->createDirectory(parent)) | ||
| return false; | ||
| } | ||
|
|
||
| auto tempPath = outputPath; | ||
| tempPath += ".tmp"; | ||
| system->deleteFile(tempPath); | ||
|
|
||
| smart_refctd_ptr<IFile> outputFile; | ||
| { | ||
| ISystem::future_t<smart_refctd_ptr<IFile>> future; | ||
| system->createFile(future, tempPath, IFileBase::ECF_WRITE); | ||
| if (!future.wait()) | ||
| return false; | ||
|
|
||
| auto lock = future.acquire(); | ||
| if (!lock) | ||
| return false; | ||
| lock.move_into(outputFile); | ||
| } | ||
| if (!outputFile) | ||
| return false; | ||
|
|
||
| if (!content.empty()) | ||
| { | ||
| IFile::success_t success; | ||
| outputFile->write(success, content.data(), 0ull, content.size()); | ||
| if (!success) | ||
| { | ||
| outputFile = nullptr; | ||
| system->deleteFile(tempPath); | ||
| return false; | ||
| } | ||
| } | ||
| outputFile = nullptr; | ||
|
|
||
| system->deleteFile(outputPath); | ||
| const auto moveError = system->moveFileOrDirectory(tempPath, outputPath); | ||
| if (moveError) | ||
| { | ||
| system->deleteFile(tempPath); | ||
| return false; | ||
| } | ||
|
|
||
| return true; |
Member
Author
There was a problem hiding this comment.
@AnastaZIuk do you think you could add an option to createFile flags (or pack the path+ IFileBase flaggs into a strcut) to create all the directories needed on the way to the path ?
cold be useful
…d weight is separate)
…=3) for RIS sampling
fix make `OwenSampler` be able to generate dimensions in parallel
Comment on lines
900
to
+907
| ((NBL_CONCEPT_REQ_TYPE)(T::scalar_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::anisotropic_interaction_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::sample_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::anisocache_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::spectral_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::quotient_pdf_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::quotient_weight_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::value_weight_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::random_type)) |
Member
Author
There was a problem hiding this comment.
TODO: can we check NBL_CONCEPT_REQ_TYPE_ALIAS_CONCEPT that these are correct:
- fundamental scalar
- interaction
- sample
- spectral type is a vector ?
- quotient and pdf type is quotient and pdf
- value and weight is value and weight
- random type is a floating point vectorial
We should probably remove quotient_pdf_type
Comment on lines
957
to
+958
| ((NBL_CONCEPT_REQ_TYPE)(T::isotropic_interaction_type)) | ||
| ((NBL_CONCEPT_REQ_EXPR_RET_TYPE)((bxdf.eval(_sample, iso)), ::nbl::hlsl::is_same_v, typename T::spectral_type)) | ||
| ((NBL_CONCEPT_REQ_EXPR_RET_TYPE)((bxdf.pdf(_sample, iso)), ::nbl::hlsl::is_same_v, typename T::scalar_type)) | ||
| ((NBL_CONCEPT_REQ_EXPR_RET_TYPE)((bxdf.quotient_and_pdf(_sample, iso)), ::nbl::hlsl::is_same_v, typename T::quotient_pdf_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE_ALIAS_CONCEPT)(concepts::FloatingPointLikeVectorial, typename T::spectral_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::isocache_type)) |
Member
Author
There was a problem hiding this comment.
TODO: check iso types meet concepts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
TODO list: