Skip to content

build(windows): do not pass -z noexecstack when cross-compiling to PE #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlandolfi90 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

build(windows): do not pass -z noexecstack when cross-compiling to PE #1444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile.cbm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,11 @@ endif
# shipped artifact. ELF-only: Apple's ld rejects -z noexecstack outright and it
# is meaningless for PE, so it is gated rather than made "common".
ELF_HARDENING_FLAGS :=
ifeq ($(IS_LINUX),yes)
# IS_LINUX comes from uname, i.e. the HOST. Cross-compiling to Windows from a
# Linux container satisfies it while emitting PE, and lld then rejects the
# unknown -z argument. Gate on the TARGET too: IS_MINGW is derived from the
# compiler's own _WIN32 define, so it names what is actually being produced.
ifeq ($(IS_LINUX)$(IS_MINGW),yesno)
ELF_HARDENING_FLAGS := -Wl,-z,noexecstack
endif

Expand Down
Loading