fix: quarantine files on EXIT_NONZERO instead of aborting chunk - #1438
Open
shashwatMishra96 wants to merge 1 commit into
Open
fix: quarantine files on EXIT_NONZERO instead of aborting chunk#1438shashwatMishra96 wants to merge 1 commit into
shashwatMishra96 wants to merge 1 commit into
Conversation
When a worker process exits with a nonzero code (e.g. internal parse-limit abort on a pathological file), treat it the same as CRASH/HANG: quarantine the offending file via the existing two-consecutive-strikes mechanism and continue indexing the rest of the chunk. Previously, EXIT_NONZERO caused the supervisor to abort the entire chunk, losing all indexed data for that directory. This is impactful for large-scale repos (Android AOSP: 253GB, 60M+ files) where machine-generated files routinely trigger internal limits. The two-consecutive-strikes intersection mechanism already guards against false quarantines — a systemic nonzero exit (e.g. bad CLI arg) produces no recurring suspect, so the intersection is empty and the supervisor gives up (same behavior as before). Tested on Android QSSI17 (253GB, 24 chunks) + QCM6490 vendor (244 chunks). Result: 11.35M nodes indexed, 0 data loss, 2 genuinely pathological files quarantined (checkpatch.pl, a 140K-line generated .ts file). Signed-off-by: Shashwat Mishra <shashwat78.nits@gmail.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a worker process exits with a nonzero code (e.g. internal parse-limit abort on a pathological file), treat it the same as CRASH/HANG: quarantine the offending file via the existing two-consecutive-strikes mechanism and continue indexing the rest of the chunk.
Previously, EXIT_NONZERO caused the supervisor to abort the entire chunk, losing all indexed data for that directory. This is impactful for large-scale repos (Android AOSP: 253GB, 60M+ files) where machine-generated files routinely trigger internal limits.
The two-consecutive-strikes intersection mechanism already guards against false quarantines — a systemic nonzero exit (e.g. bad CLI arg) produces no recurring suspect, so the intersection is empty and the supervisor gives up (same behavior as before).
Tested on Android QSSI17 (253GB, 24 chunks) + QCM6490 vendor (244 chunks). Result: 11.35M nodes indexed, 0 data loss, 2 genuinely pathological files quarantined (checkpatch.pl, a 140K-line generated .ts file).
What does this PR do?
Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)