Skip to content

Fix BOM ref values in dependency graph warning log #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zureno wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix BOM ref values in dependency graph warning log #5909

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98611e3
arn on duplicate service BOM refs during BOM processing
Zureno Mar 15, 2026
c272412
Fix BOM ref values in dependency graph warning log
Zureno Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/main/java/org/dependencytrack/tasks/BomUploadProcessingTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,13 @@ private static Predicate<ServiceComponent> distinctServicesByIdentity(
final var identitiesSeen = new HashSet<ComponentIdentity>();
return service -> {
final var componentIdentity = new ComponentIdentity(service);
identitiesByBomRef.putIfAbsent(service.getBomRef(), componentIdentity);
final boolean isBomRefUnique = identitiesByBomRef.putIfAbsent(service.getBomRef(), componentIdentity) == null;
if (!isBomRefUnique) {
LOGGER.warn("""
BOM ref %s is associated with multiple services in the BOM; \
BOM refs are required to be unique; Please report this to the vendor \
of the tool that generated the BOM""".formatted(service.getBomRef()));
Comment thread
Zureno marked this conversation as resolved.
}
bomRefsByIdentity.put(componentIdentity, service.getBomRef());
final boolean isSeenBefore = !identitiesSeen.add(componentIdentity);
if (LOGGER.isDebugEnabled() && isSeenBefore) {
Expand Down Expand Up @@ -715,7 +721,7 @@ private String resolveDirectDependenciesJson(
LOGGER.warn("""
Unable to resolve BOM ref %s to a component identity while processing direct \
dependencies of BOM ref %s; As a result, the dependency graph will likely be incomplete\
""".formatted(dependencyBomRef, directDependencyBomRef));
""".formatted(directDependencyBomRef, dependencyBomRef));
}
}

Expand Down
Loading