Skip to content

Improve SLA breach notification format and display #14746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maffooch merged 1 commit into from
Apr 24, 2026
+7 −6
Merged

Improve SLA breach notification format and display #14746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dojo/templates/notifications/mail/sla_breach.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@
{% if sla_age < 0 %}
{% blocktranslate trimmed %}
This security finding has breached its SLA.

- Day(s) overdue: {{sla}}
<br/>
- Day(s) overdue: {{sla_age}}
{% endblocktranslate %}
{% else %}
{% blocktranslate trimmed %}
A security finding is about to breach its SLA.

- Day(s) remaining: {{sla}}
<br/>
- Day(s) remaining: {{sla_age}}
{% endblocktranslate %}
{% endif %}
</p>
Expand Down
5 changes: 3 additions & 2 deletions dojo/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1576,12 +1576,13 @@ def _create_notifications():
findings_list = []

for n in comb_notif_kind:
title = _notification_title_for_finding(n.finding, kind, n.finding.sla_days_remaining())

sla_age = n.finding.sla_days_remaining()
title = _notification_title_for_finding(n.finding, kind, sla_age)
create_notification(
event="sla_breach",
title=title,
finding=n.finding,
sla_age=sla_age,
url=reverse("view_finding", args=(n.finding.id,)),
)

Expand Down
Loading