Repository navigation
docs(owner-budget): correct three comments on #1557's code - #1567
Draft
DealAppSeo wants to merge 1 commit into
Draft
DealAppSeo wants to merge 1 commit into
DealAppSeo wants to merge 1 commit into
Conversation
's code (review of #1557) - owner-budget.ts: an account is not proof the wallet signed. POST /builder/register makes one behind an API key with no signature, so "only created for a wallet that signed" was false. - routes/agent-spend.ts: loadOwnerBuilder is null when there is no funding account, not "if not a builder"; a human_sbt owner has one with HUMAN_SBT_OWNER_BUDGET_ENABLED=true. - e2e owner-budget-testnet.ts: no_owner_budget surfaces at step 3b only in stake mode; in wallet mode 3b does not run and step R answers it. Comments only; no behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner action
None needed from you (LOW: comments only, no behaviour change). This replaces #1565, which conflicted with
mainonce #1557 squash-merged; the guard blocks mergingmaininto a branch, so the same commit was cherry-picked ontomaininstead (identical diff). Under D-161, Claude merges it once Claude, Grok, Strix and all CI pass on one SHA; none has run yet.What this is
Three comments on #1557's code said the wrong thing (independent review of #1557). #1557 is now merged as
dc23512c; these comments still read as below onmain.src/services/owner-budget.ts(ownerBuilderOfAgent doc). It said an account "is only created for a wallet that signed (POST /account/connect)". That is false:POST /builder/registerinserts one behind an API key, with no signature from the wallet [Vsrc/routes/v1.ts/builder/register→registerBuilderinserts intobuilders]. The comment now says an account is not proof of consent: what funds the budget is the stake, and two accounts for one wallet are refused as ambiguous [V, therows.length > 1throw in the same function].src/routes/agent-spend.ts(loadOwnerBuilderdoc). It said "null if not a builder". A verified human owner now has a funding account whenHUMAN_SBT_OWNER_BUDGET_ENABLED=true, so it says "null if there is none" and names both cases.scripts/e2e/owner-budget-testnet.ts(step 3 comment). It said step 3b answersno_owner_budget. Step 3b (spend limits) runs only in stake mode; in wallet mode step R answers it [V:if (fromStake)around 3b;no_owner_budgetis answered by both the spend-limit route and the spend dry run inroutes/agent-spend.ts].Comments only: the diff touches no executable line.
🤖 Generated with Claude Code