Repository navigation
fix(lane): the public lane report never echoes a read error (Strix on #1559) - #1566
Draft
DealAppSeo wants to merge 1 commit into
Draft
DealAppSeo wants to merge 1 commit into
DealAppSeo wants to merge 1 commit into
Conversation
…1559) GET /api/v1/lane/:agent is public. Its allowance read put the ethers error into the gate detail, and ethers carries the request URL (info.requestUrl), so an anonymous caller could read the RPC provider URL and any key in it whenever the read failed. The agent and binding reads did the same with database errors. All three now log the text and answer a fixed phrase. Same class as #1559's unbind fix and #1558's gasless answers; this file is on main, so the fix is here and #1559's head stays as reviewed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner action
None needed from you tonight. This is MEDIUM: security hardening of a public API answer, touching nothing on the MAJOR list. Under D-161 Claude merges it once Claude, Grok, Strix and all CI pass on one SHA. Grok has not run on it yet, and nothing is merged tonight.
What this is
Strix found this on #1559 (comment 4583891478); it is a pre-existing site of the same class.
GET /api/v1/lane/:agentis public. When its allowance read failed,practice-lane.tsput the ethers error text into the gate detail. ethers carries the request URL (info.requestUrl), so an anonymous caller could read the RPC provider URL and any key in its path. The agent and binding reads in the same function did the same with database error text.All three now log the error text and answer a fixed phrase:
The fix is here, not on #1559, because this file is on
mainand #1559's head stays as reviewed for tomorrow's packet.Evidence
E:\dev\reports\2026-11-16\r-loop\lane.test-output-head.txt: 12/12 pass on this branch.lane.test-output-old-src.txt: the same tests againstmain'spractice-lane.ts(5e3cb787). The new no-echo test fails with the leaked URL in the answer.tsc --noEmitis clean.The other sites of this class on
/stake/depositand the spend route are still open as a separate follow-up.🤖 Generated with Claude Code