Skip to content

fix(lane): the public lane report never echoes a read error (Strix on #1559) - #1566

Draft
DealAppSeo wants to merge 1 commit into
mainfrom
claude/lane-no-raw-errors
Draft

DealAppSeo wants to merge 1 commit into
mainfrom
claude/lane-no-raw-errors

Conversation

@DealAppSeo

Copy link
Copy Markdown
Owner

Owner action

None needed from you tonight. This is MEDIUM: security hardening of a public API answer, touching nothing on the MAJOR list. Under D-161 Claude merges it once Claude, Grok, Strix and all CI pass on one SHA. Grok has not run on it yet, and nothing is merged tonight.

What this is

Strix found this on #1559 (comment 4583891478); it is a pre-existing site of the same class. GET /api/v1/lane/:agent is public. When its allowance read failed, practice-lane.ts put the ethers error text into the gate detail. ethers carries the request URL (info.requestUrl), so an anonymous caller could read the RPC provider URL and any key in its path. The agent and binding reads in the same function did the same with database error text.

All three now log the error text and answer a fixed phrase:

  • agent read: "the database read failed"
  • binding read: "the database read failed"
  • allowance read: "the RPC read failed"

The fix is here, not on #1559, because this file is on main and #1559's head stays as reviewed for tomorrow's packet.

Evidence

  • E:\dev\reports\2026-11-16\r-loop\lane.test-output-head.txt: 12/12 pass on this branch.
  • lane.test-output-old-src.txt: the same tests against main's practice-lane.ts (5e3cb787). The new no-echo test fails with the leaked URL in the answer.
  • tsc --noEmit is clean.

The other sites of this class on /stake/deposit and the spend route are still open as a separate follow-up.

🤖 Generated with Claude Code

…1559)

GET /api/v1/lane/:agent is public. Its allowance read put the ethers error into the gate detail, and
ethers carries the request URL (info.requestUrl), so an anonymous caller could read the RPC provider
URL and any key in it whenever the read failed. The agent and binding reads did the same with database
errors. All three now log the text and answer a fixed phrase. Same class as #1559's unbind fix and
#1558's gasless answers; this file is on main, so the fix is here and #1559's head stays as reviewed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DealAppSeo DealAppSeo added the grok-review Ask the grok-review loop to review this PR (also drafts) label Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grok-review Ask the grok-review loop to review this PR (also drafts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant