Skip to content

fix(check-sdk-claims): run on Windows instead of reporting NOT_CHECKED - #53

Merged
DealAppSeo merged 1 commit into
mainfrom
claude/2026-10-14-sdk-claims-windows
Oct 14, 2026
Merged

DealAppSeo merged 1 commit into
mainfrom
claude/2026-10-14-sdk-claims-windows

Conversation

@DealAppSeo

Copy link
Copy Markdown
Owner

scripts/check-sdk-claims.mjs calls execFileSync('npm', …). On Windows npm is npm.cmd and needs a shell, so the call throws ENOENT and the check reports NOT_CHECKED on every Windows run. The operator's machine and the local agents could never actually run it. check-builders.mjs already handles this; this mirrors it.

Windows output
before check:sdk-claims — NOT_CHECKED · spawnSync npm ENOENT
after check:sdk-claims — VERIFIED · 1 README call site(s) all exist on @hyperdag/trustshell@1.6.1: verifyOutput

On Linux (CI) the command, args and options are the same as before (shell: false).

🤖 Generated with Claude Code

`npm` is `npm.cmd` on Windows and needs a shell, so execFileSync('npm', ...)
threw ENOENT and the check reported NOT_CHECKED on every Windows run: the
operator's machine and the local agents could never run it. Mirrors the
handling check-builders.mjs already has. Linux (CI) path is unchanged.

Windows, before: NOT_CHECKED (spawnSync npm ENOENT).
Windows, after:  VERIFIED (1 README call site exists on @hyperdag/trustshell@1.6.1).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@strix-security

strix-security Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Strix Security Review

No security issues found.

Review summary

Reviewed the single-file change to scripts/check-sdk-claims.mjs, which makes the npm pack invocation work on Windows by using npm.cmd with shell:true (and windowsHide:true), mirroring the existing check-builders.mjs pattern. The command and all arguments are hardcoded constants (PKG is a module-level literal '@hyperdag/trustshell'), so enabling the shell on Windows introduces no command-injection surface. The tar extraction operates on a filename from a freshly created temp directory, not attacker input. This is a build-time verification script with no user-controlled input, secrets, or runtime exposure. No security issues found.

Updated for 5920825.


Reviewed by Strix
Re-run review · Configure security review settings

@DealAppSeo
DealAppSeo merged commit 7138a76 into main Oct 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant