Repository navigation
fix(check-sdk-claims): run on Windows instead of reporting NOT_CHECKED - #53
Conversation
`npm` is `npm.cmd` on Windows and needs a shell, so execFileSync('npm', ...)
threw ENOENT and the check reported NOT_CHECKED on every Windows run: the
operator's machine and the local agents could never run it. Mirrors the
handling check-builders.mjs already has. Linux (CI) path is unchanged.
Windows, before: NOT_CHECKED (spawnSync npm ENOENT).
Windows, after: VERIFIED (1 README call site exists on @hyperdag/trustshell@1.6.1).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Strix Security ReviewNo security issues found. Review summaryReviewed the single-file change to scripts/check-sdk-claims.mjs, which makes the npm pack invocation work on Windows by using npm.cmd with shell:true (and windowsHide:true), mirroring the existing check-builders.mjs pattern. The command and all arguments are hardcoded constants (PKG is a module-level literal '@hyperdag/trustshell'), so enabling the shell on Windows introduces no command-injection surface. The tar extraction operates on a filename from a freshly created temp directory, not attacker input. This is a build-time verification script with no user-controlled input, secrets, or runtime exposure. No security issues found. Updated for Reviewed by Strix |
scripts/check-sdk-claims.mjscallsexecFileSync('npm', …). On Windowsnpmisnpm.cmdand needs a shell, so the call throwsENOENTand the check reports NOT_CHECKED on every Windows run. The operator's machine and the local agents could never actually run it.check-builders.mjsalready handles this; this mirrors it.check:sdk-claims — NOT_CHECKED·spawnSync npm ENOENTcheck:sdk-claims — VERIFIED·1 README call site(s) all exist on @hyperdag/trustshell@1.6.1: verifyOutputOn Linux (CI) the command, args and options are the same as before (
shell: false).🤖 Generated with Claude Code