Skip to content

Approval changes

744c36f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Accept a Func<SqlConnection> instead of a pre-created connection #34

Approval changes
744c36f
Select commit
Loading
Failed to load commit list.
GitHub Actions / Unit Tests succeeded Feb 24, 2026 in 0s

47 passed, 0 failed and 0 skipped

Tests passed successfully

✅ _runnervmwffz4_2026-02-24_03_56_33.trx

47 tests were completed in 959ms with 47 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
DbUp.SqlServer.Tests.DatabaseSupportTests 3✅ 148ms
DbUp.SqlServer.Tests.MicrosoftDataSqlClientVersionTests 2✅ 4ms
DbUp.SqlServer.Tests.NoPublicApiChanges 1✅ 220ms
DbUp.SqlServer.Tests.SqlCommandSplitterTests 16✅ 31ms
DbUp.SqlServer.Tests.SqlObjectParserTests 10✅ 4ms
DbUp.SqlServer.Tests.SqlParserTests 3✅ 2ms
DbUp.SqlServer.Tests.SqlScriptExecutorTests 12✅ 197ms

✅ DbUp.SqlServer.Tests.DatabaseSupportTests

✅ VerifyBasicSupport
✅ VerifyJournalCreationIfNameChanged
✅ VerifyVariableSubstitutions

✅ DbUp.SqlServer.Tests.MicrosoftDataSqlClientVersionTests

✅ Microsoft_Data_SqlClient_Is_In_Support
✅ Microsoft_Data_SqlClient_Is_Lowest_Supported_Lts

✅ DbUp.SqlServer.Tests.NoPublicApiChanges

✅ Run

✅ DbUp.SqlServer.Tests.SqlCommandSplitterTests

✅ does_not_split_go_in_column_name
✅ multiple_brackets_should_escape_properly
✅ should_correctly_recognize_go_statements(SqlText: " GO", expectedCommands: [])
✅ should_correctly_recognize_go_statements(SqlText: "--Dummy comment\nGO", expectedCommands: ["--Dummy comment"])
✅ should_correctly_recognize_go_statements(SqlText: "\nGO", expectedCommands: [])
✅ should_correctly_recognize_go_statements(SqlText: "GO ", expectedCommands: [])
✅ should_correctly_recognize_go_statements(SqlText: "GO--Dummy comment", expectedCommands: ["GO--Dummy comment"])
✅ should_correctly_recognize_go_statements(SqlText: "GO", expectedCommands: [])
✅ should_correctly_recognize_go_statements(SqlText: "GO\n", expectedCommands: [])
✅ should_correctly_recognize_go_statements(SqlText: "GO\nGO--Dummy comment", expectedCommands: ["GO--Dummy comment"])
✅ should_handle_nested_multiline_comments(sqlWithNestedMultilineComment: "/*/*/*/*/**/*/*/*/*/", expectedCommands: ["/*/*/*/*/**/*/*/*/*/"])
✅ should_handle_nested_multiline_comments(sqlWithNestedMultilineComment: "/*/*/*/*/*\nGO\n*/*/*/*/*/", expectedCommands: ["/*/*/*/*/*\nGO\n*/*/*/*/*/"])
✅ should_handle_nested_multiline_comments(sqlWithNestedMultilineComment: "\n/* comment1 /* comment2 */*/\nSELECT * FROM[Exam"···, expectedCommands: ["/* comment1 /* comment2 */*/\nSELECT * FROM[Exampl"···, "SELECT TOP 1[Id] FROM[SomewhereElse]", "EXEC sp_SomeStoredProc;"])
✅ should_handle_nested_multiline_comments(sqlWithNestedMultilineComment: "\n/* comment1 /* comment2 */*/\nSELECT * FROM[Exam"···, expectedCommands: ["/* comment1 /* comment2 */*/\nSELECT * FROM[Exampl"···])
✅ should_split_statements_on_go_and_handle_comments
✅ should_treat_bracketed_text_as_single_item

✅ DbUp.SqlServer.Tests.SqlObjectParserTests

✅ QuoteSqlObjectName_should_fail_on_empty_object_name
✅ QuoteSqlObjectName_should_fail_on_large_object_name
✅ QuoteSqlObjectName_should_fail_on_null_object_name
✅ QuoteSqlObjectName_should_not_change_a_quoted_object_name
✅ QuoteSqlObjectName_should_quote_an_unquoted_object_name
✅ QuoteSqlObjectName_should_quote_and_escape_closing_brackets_in_object_name
✅ QuoteSqlObjectName_should_quote_and_not_escape_opening_brackets_in_object_name
✅ QuoteSqlObjectName_should_quote_and_trim_an_unquoted_object_name
✅ QuoteSqlObjectName_should_trim_a_quoted_object_name
✅ QuoteSqlObjectName_without_trim_should_leave_start_and_end_whitespace_intact

✅ DbUp.SqlServer.Tests.SqlParserTests

✅ should_accept_other_delimiters
✅ should_handle_delimiter_at_the_eof
✅ shouldnt_change_parsed_script

✅ DbUp.SqlServer.Tests.SqlScriptExecutorTests

✅ does_not_use_variable_substitute_preprocessor_when_setting_false
✅ logs_output_when_configured_to
✅ logs_when_dbexception
✅ uses_variable_substitute_preprocessor_when_running_scripts
✅ uses_variable_substitute_preprocessor_when_running_scripts_with_multi_line_comment
✅ uses_variable_substitute_preprocessor_when_running_scripts_with_nested_comment
✅ uses_variable_substitute_preprocessor_when_running_scripts_with_nested_single_line_comment
✅ uses_variable_substitute_preprocessor_when_running_scripts_with_one_line_comment
✅ uses_variable_subtitute_preprocessor_when_running_scripts_with_single_line_comment
✅ uses_variable_subtitutes_schema
✅ verify_schema_should_not_check_when_schema_is_null
✅ when_schema_is_null_schema_is_stripped_from_scripts