Extend fnAddTr to allow updating an existing TR node instead of adding#8
Open
chmielot wants to merge 1 commit intoDataTables:masterfrom
Open
Extend fnAddTr to allow updating an existing TR node instead of adding#8chmielot wants to merge 1 commit intoDataTables:masterfrom
chmielot wants to merge 1 commit intoDataTables:masterfrom
Conversation
…ead of adding a new TR to the DataTables table.
Collaborator
|
I think the update option might be better in an fnUpdateTr plug-in? DataTables 1.10 is going to include an 'invalidate' method so you'll be able to update the DOM directly and then call invalidate() on the row/column/cell and have DataTables re-read the stored information, which sounds relevant here (although not yet implemented, so not yet massively useful!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use case is the following:
Given a DataTable with an actions column. One of the actions changes the row's data via ajax, so that the row actually changed. The ajax request returns a freshly rendered row for the changed entity. To not reload the whole table and lose current filter, pagination or any other settings, the row should be updated.
fnAddTr only allows to add new rows. This patch adds a parameter which can be a TR node or an index, like described in the fnUpdate API. If this parameter is set, the passed node will be updated with the new one.
I'm just not sure if extending fnAddTr is the best idea. Alternatives are:
What do you think?