feat(trace-utils)!: add from_string to span text#2011
Open
VianneyRuhlmann wants to merge 7 commits into
Open
Conversation
Contributor
📚 Documentation Check Results📦
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
🔒 Cargo Deny Results📦
|
bantonsson
reviewed
May 19, 2026
| /// Note: Borrow<str> is not required by the derived traits, but allows to access HashMap elements | ||
| /// from a static str and check if the string is empty. | ||
| pub trait SpanText: Debug + Eq + Hash + Borrow<str> + Serialize + Default { | ||
| pub trait SpanText: Debug + Eq + Hash + Borrow<str> + Serialize + Default + From<String> { |
Contributor
There was a problem hiding this comment.
What does this trait bound add? I can't see that it's necessary.
Contributor
Author
There was a problem hiding this comment.
It allows to store new strings in the span e.g. an normalized/obfuscated version of a value. Otherwise SpanText instance can only be created from static str.
Contributor
There was a problem hiding this comment.
If that's the case, then maybe there should be code in the PR that needs it, since everything compiles fine without that trait bound.
Contributor
Author
There was a problem hiding this comment.
It's needed by @Eldolfin work on the trace filters. It seemed cleaner to do this change separately to be able to discuss it
yannham
reviewed
May 19, 2026
Contributor
yannham
left a comment
yannham
left a comment
There was a problem hiding this comment.
Just trying to understand the blast radius: who is using the now cow-based SpanSlice implementation in practice? Is it only for tests, or do others have to pay the cow tax? Maybe it's unavoidable, because any SDK has do deal with the filter/normalization issue anyway?
Contributor
Author
|
iirc we only use it in the trace_utils decoder when decoding from a slice which is done by python and is going to be used by ruby. All sdks may need to use normalization/obfuscation but not all customers will (for now only those using trace filters). I can add an extra trait |
yannham
approved these changes
May 19, 2026
Contributor
yannham
left a comment
yannham
left a comment
There was a problem hiding this comment.
I see, thanks. I don't think it's worth the effort anyway, since we're moving towards native spans, and it's not clear that Cow has any measurable impact (it does double the size of &str, but whether that makes any difference...).
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 3f09f0b | Docs | Datadog PR Page | Give us feedback! |
VianneyRuhlmann
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2011 +/- ##
==========================================
+ Coverage 72.67% 72.71% +0.03%
==========================================
Files 452 452
Lines 74889 74946 +57
==========================================
+ Hits 54427 54494 +67
+ Misses 20462 20452 -10
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make the span fields mutable by requiring From on SpanText and switching SpanSlice to use Cow
Motivation
Needed to apply normalization on the span, required by trace filters.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.