Skip to content

chore(deps): bump rand as the current version has an adviosry #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paullegranddc wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore(deps): bump rand as the current version has an adviosry #1975

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b60067
chore(deps): bump rand as the current version has an adviosry
paullegranddc May 11, 2026
8c9c095
fix: adapt to rand 0.10 API and wasm getrandom feature
paullegranddc May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
351 changes: 283 additions & 68 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion datadog-sidecar/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ http-body-util = "0.1"
datadog-ipc = { path = "../datadog-ipc", features = ["tiny-bytes"] }
datadog-ipc-macros = { path = "../datadog-ipc-macros" }

rand = "0.8.3"
rand = "0.10.1"
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep rand below the workspace MSRV

When the CI matrix runs with Rust 1.84.1 (.github/workflows/test.yml and lint.yml) this dependency bump makes Cargo reject the build before compiling, because rand 0.10.1 declares rust-version = "1.85" while the workspace still advertises rust-version = "1.84.1" in the root Cargo.toml. Unless the workspace MSRV and CI are bumped together, every crate that now depends on rand = "0.10.1" will fail in the 1.84.1 jobs.

Useful? React with 👍 / 👎.

rmp-serde = "1.1.1"
libdd-trace-protobuf = { path = "../libdd-trace-protobuf" }
serde = { version = "1.0", features = ["derive", "rc"] }
Expand Down
4 changes: 2 additions & 2 deletions datadog-sidecar/src/service/queue_id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright 2021-Present Datadog, Inc. https://www.datadoghq.com/
// SPDX-License-Identifier: Apache-2.0

use rand::Rng;
use rand::RngExt as _;
use serde::{Deserialize, Serialize};

/// `QueueId` is a struct that represents a unique identifier for a queue.
Expand All @@ -27,7 +27,7 @@ impl QueueId {
/// ```
pub fn new_unique() -> Self {
Self {
inner: rand::thread_rng().gen_range(1u64..u64::MAX),
inner: rand::rng().random_range(1u64..u64::MAX),
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions libdd-common/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ mime = { version = "0.3.16", optional = true }
multer = { version = "3.1", optional = true }
bytes = { version = "1.11.1" }
pin-project = "1"
rand = { version = "0.8", optional = true }
rand = { version = "0.10.1", optional = true }
regex = "1.5"
regex-lite = { version = "0.1", optional = true }
# Use hickory-dns instead of the default system DNS resolver to avoid fork safety issues.
Expand Down Expand Up @@ -85,7 +85,7 @@ maplit = "1.0"
mime = "0.3.16"
multer = "3.1"
bytes = "1.11.1"
rand = "0.8"
rand = "0.10.1"
tempfile = "3.8"
tokio = { version = "1.23", features = ["rt", "macros", "time"] }

Expand Down
2 changes: 1 addition & 1 deletion libdd-crashtracker/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ num-traits = "0.2.19"
os_info = "3.14.0"
page_size = "0.6.0"
portable-atomic = { version = "1.6.0", features = ["serde"] }
rand = "0.8.5"
rand = "0.10.1"
schemars = "0.8.21"
serde = {version = "1.0", features = ["derive"]}
serde_json = {version = "1.0"}
Expand Down
6 changes: 3 additions & 3 deletions libdd-crashtracker/src/collector/atomic_set.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
//! If this is useful for other cases, we can consider moving it to ddcommon.

use portable_atomic::AtomicUsize;
use rand::Rng;
use rand::RngExt as _;
use std::fmt::Debug;
use std::io::Write;
use std::num::NonZeroU128;
Expand Down Expand Up @@ -141,7 +141,7 @@ where
// Long scans become exponentially unlikely, giving amortized constant time insertion.
// Try 10 random locations, this should succeed 0.999 of the time.
for _ in 0..10 {
let idx: usize = rand::thread_rng().gen_range(0..self.set.len());
let idx: usize = rand::rng().random_range(0..self.set.len());
if let Some(v) = self.set[idx].try_insert(value) {
value = v;
} else {
Expand All @@ -152,7 +152,7 @@ where
// In the case where it doesn't succeed, do a linear probe to guarantee it lands somewhere.
// Since we enforce that the array is only half full, this is guarantee to succeed.
// We leave this to second to avoid the chains that can build up with linear probing.
let shift: usize = rand::thread_rng().gen_range(0..self.set.len());
let shift: usize = rand::rng().random_range(0..self.set.len());
for i in 0..self.set.len() {
let idx = (i + shift) % self.set.len();

Expand Down
2 changes: 1 addition & 1 deletion libdd-data-pipeline/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ libdd-trace-utils = { path = "../libdd-trace-utils", features = [
"test-utils",
] }
httpmock = "0.8.0-alpha.1"
rand = "0.8.5"
rand = "0.10.1"
tempfile = "3.3.0"
tokio = { version = "1.23", features = [
"rt",
Expand Down
2 changes: 1 addition & 1 deletion libdd-library-config/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ serde_yaml = "0.9.34"
prost = "0.14.1"
anyhow = "1.0"

rand = "0.8.3"
rand = "0.10.1"
rmp = "0.8.14"
rmp-serde = "1.3.0"

Expand Down
2 changes: 1 addition & 1 deletion libdd-profiling/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ libdd-profiling-protobuf = { version = "2.0.0", path = "../libdd-profiling-proto
mime = "0.3.16"
parking_lot = { version = "0.12", default-features = false }
prost = "0.14.1"
rand = "0.8"
rand = "0.10.1"
# Use rustls to align with the rest of the workspace (libdd-common, libdd-telemetry, etc.)
# Non-FIPS builds use ring as the crypto provider; FIPS builds use aws-lc-rs.
# Use hickory-dns instead of the default system DNS resolver to avoid fork safety issues.
Expand Down
2 changes: 1 addition & 1 deletion libdd-trace-normalization/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ arbitrary = { version = "1.3", features = ["derive"], optional = true }
fuzzing = ["arbitrary"]

[dev-dependencies]
rand = "0.8.5"
rand = "0.10.1"
duplicate = "0.4.1"
criterion = "0.5"

Expand Down
2 changes: 1 addition & 1 deletion libdd-trace-stats/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ path = "benches/main.rs"
criterion = "0.5.1"
httpmock = "0.8.0-alpha.1"
libdd-trace-utils = { path = "../libdd-trace-utils", features = ["test-utils"] }
rand = "0.8.5"
rand = "0.10.1"
tokio = { version = "1.23", features = ["rt-multi-thread", "macros", "test-util", "time"], default-features = false }

[features]
Expand Down
2 changes: 1 addition & 1 deletion libdd-trace-utils/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ tracing = { version = "0.1", default-features = false }
serde_json = "1.0"
futures = { version = "0.3", default-features = false }
tokio = { version = "1", features = ["macros"] }
rand = "0.8.5"
rand = "0.10.1"
bytes = "1.11.1"
rmpv = { version = "1.3.0", default-features = false }
rmp = { version = "0.8.14", default-features = false }
Expand Down
Loading