Skip to content

crashtracker: JSON-encode panic message transport to prevent protocol injection #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paullegranddc wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Draft

crashtracker: JSON-encode panic message transport to prevent protocol injection #1966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libdd-crashtracker/src/collector/emitters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ fn emit_message(w: &mut impl Write, message_ptr: *mut String) -> Result<(), Emit
let message = unsafe { &*message_ptr };
if !message.trim().is_empty() {
writeln!(w, "{DD_CRASHTRACK_BEGIN_MESSAGE}")?;
writeln!(w, "{message}")?;
writeln!(w, "{}", serde_json::to_string(message)?)?;
writeln!(w, "{DD_CRASHTRACK_END_MESSAGE}")?;
w.flush()?;
}
Expand Down
1 change: 1 addition & 0 deletions libdd-crashtracker/src/receiver/receive_report.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,7 @@ mod tests {
assert!(builder.has_message());
}


#[test]
fn test_stdin_state_message_to_waiting() {
let mut builder = CrashInfoBuilder::new();
Expand Down
Loading