Skip to content

fix(observability-pipelines-worker): correct sgc_path in bootstrap template #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 5 commits into from
Sep 2, 2026
Merged

fix(observability-pipelines-worker): correct sgc_path in bootstrap template #2883

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccb9043
fix(observability-pipelines-worker): correct sgc_path in bootstrap te…
ckelner Aug 28, 2026
1fe094c
Omit sgc_path from template, add changelog, bump to 2.21.2
ckelner Aug 31, 2026
d052eab
Use hasKey instead of dig truthiness to detect secret block
ckelner Aug 31, 2026
63c1213
Merge branch 'main' into ckelner/fix-opw-sgc-path-bootstrap
ckelner Aug 31, 2026
9e8b3b6
bump version in readme
tessneau Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/observability-pipelines-worker/templates/bootstrap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ data:
{{- if .Values.datadog.bootstrap.config }}
{{- toYaml .Values.datadog.bootstrap.config | nindent 4 }}
{{- end }}
{{- if .Values.datadog.bootstrap.secretFileContents }}
{{- if and .Values.datadog.bootstrap.secretFileContents (not (dig "secret" nil .Values.datadog.bootstrap.config)) }}
Comment thread
ckelner marked this conversation as resolved.
Outdated
secret:
sgc_path: /opt/datadog/observability-pipelines-worker/bin/datadog-secret-backend
sgc_path: /opt/datadog/observability-pipelines-worker/bin/sgc

@tessneau tessneau Aug 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like OPW defaults secret.sgc_path when it's omitted -- see the default setting to /sgc in 2.21.1 & this test

That default matches the sgc binary since 2.13.0, whereas the change to /sgc happened in 2.15.1. Should we simply omit secret.sgc_path from the template and defer to the worker default?

(note i haven't seen the google doc yet)

@tessneau tessneau Aug 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok yeah I stand by this after looking at the doc. Changing the hardcoded path works too but omitting it fully to defer to the default feels a tad nicer

backend_type: json
backend_config:
file_path: /etc/observability-pipelines-secrets/secrets.json
Expand Down
Loading