chore: debug known tests pagination#18264
Draft
gnufede wants to merge 11 commits into
Draft
Conversation
Contributor
|
gnufede
changed the title
BenchmarksBenchmark execution time: 2026-05-26 09:33:41 Comparing candidate commit 661a367 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 617 metrics, 10 unstable metrics. scenario:iastaspects-lstrip_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:span-start
scenario:telemetryaddmetric-1-count-metric-1-times
|
gnufede
commented
May 27, 2026
Codeowners resolved as |
… pagination When the backend returns `size` in the response `page_info`, echo it back as `page_size` in the next request's `page_info`. Also adds debug logging for request/response page_info on each page, an AIDEV-NOTE on the variable reuse issue, and a full-payload test for the second-page request shape. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…line Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
_get_expected_do_request_tests_payload is for _api_client.py which still
sends {} on the first page. Only ddtrace/testing/internal/api_client.py
sends {"page_size": 2000}.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lient tests
_api_client.py sends {} on the first page (no default page_size);
only ddtrace/testing/internal/api_client.py sends {"page_size": 2000}.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… request Let the backend use its default page size instead of sending page_size: 2000. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Risks
Additional Notes