feat(ffe): wire remote config lifecycle#3904
Closed
leoromanovsky wants to merge 1 commit into
Closed
Conversation
|
Benchmarks [ tracer ]Benchmark execution time: 2026-05-22 02:02:17 Comparing candidate commit cae2759 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 194 metrics, 0 unstable metrics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Continue the OpenFeature PHP compatibility stack by wiring the native evaluator to Remote Config. This PR follows the libdatadog import pattern from #3630 so the tracer subscribes to FFE Remote Config payloads and hands them to
datadog-ffeinstead of parsing or evaluating rules in PHP.Reference design doc: https://docs.google.com/document/d/1NvMfTpZWLBlFmEFNjdnlMyeVpy5l7KD8qujGFco6w2w/edit?tab=t.0
Stack base: #3903
Changes
ffefeature ondatadog-remote-config.ddog_init_remote_configbools with a named C-ABI flags struct.DD_EXPERIMENTAL_FLAGGING_PROVIDER_ENABLED, defaulting tofalse.FFE_FLAGSplusFfeFlagConfigurationRulesonly when the experimental provider is enabled.datadog_ffe::rules_based::Configurationon FFE Remote Config add/remove events.Decisions
DD_EXPERIMENTAL_FLAGGING_PROVIDER_ENABLED=falseso partially landed stack work does not surprise users.libdatadog/datadog-ffe; PHP only bridges config lifecycle and evaluation calls.request-replayer, matching existing Remote Config tests.Validation
git diff --checkphp -n -l tests/ext/ffe/remote_config_lifecycle.phptRUSTC_BOOTSTRAP=1 cargo check -p ddtrace-phpEXTRA_CFLAGS="-I$(brew --prefix pcre2)/include" EXTRA_LDFLAGS="-L$(brew --prefix pcre2)/lib" make -j"$(sysctl -n hw.ncpu)"php -n -d extension=tmp/build_extension/modules/ddtrace.so -m | rg -i '^ddtrace$'make test_c TESTS=tests/ext/ffe/native_bridge_evaluate.phptmake test_c TESTS=tests/ext/ffe/remote_config_lifecycle.phptskipped locally becauserequest-replayeris not available outside the Datadog dev env.