test(ws): refactor lifecycle hooks to use dynamic ports and separate afterEach - #8367
Merged
Conversation
…afterEach - Replace hardcoded ports (6015, 16015) with port 0 so the kernel assigns an available port, eliminating inter-run port conflicts - Move regression-test resource cleanup (server, socket) from test bodies into dedicated afterEach hooks - Split combined afterEach callbacks into one hook per concern so a failure in one cleanup step doesn't skip the others - Load/close the agent in beforeEach/afterEach instead of before/after so each test gets a clean agent state Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
Overall package sizeSelf size: 5.8 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: bb58141 | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-05-09 10:50:40 Comparing candidate commit bb58141 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1732 metrics, 112 unstable metrics. |
bm1549
reviewed
May 8, 2026
|
|
||
| const dc = require('dc-polyfill') | ||
| const { after, afterEach, before, beforeEach, describe, it } = require('mocha') | ||
| const setSocketCh = dc.channel('tracing:ws:server:connect:setSocket') |
Collaborator
There was a problem hiding this comment.
Non-blocking, but with DataDog/dc-polyfill#27 this isn't really needed anymore
Member
Author
There was a problem hiding this comment.
That is indeed redundant from a fix perspective, but it's still good practice to call channel only once at the top, so no harm in keeping it like that.
BridgeAR
approved these changes
May 9, 2026
BridgeAR
enabled auto-merge (squash)
May 9, 2026 10:38
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
May 10, 2026
…afterEach (#8367) - Replace hardcoded ports (6015, 16015) with port 0 so the kernel assigns an available port, eliminating inter-run port conflicts - Move regression-test resource cleanup (server, socket) from test bodies into dedicated afterEach hooks - Split combined afterEach callbacks into one hook per concern so a failure in one cleanup step doesn't skip the others - Load/close the agent in beforeEach/afterEach instead of before/after so each test gets a clean agent state - Move channel declaration to top of file --------- Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
rochdev
added a commit
that referenced
this pull request
May 13, 2026
…afterEach (#8367) - Replace hardcoded ports (6015, 16015) with port 0 so the kernel assigns an available port, eliminating inter-run port conflicts - Move regression-test resource cleanup (server, socket) from test bodies into dedicated afterEach hooks - Split combined afterEach callbacks into one hook per concern so a failure in one cleanup step doesn't skip the others - Load/close the agent in beforeEach/afterEach instead of before/after so each test gets a clean agent state - Move channel declaration to top of file --------- Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
port: 0so the kernel assigns an available port, eliminating inter-run conflictsafterEachhooksafterEachcallbacks into one hook per concern so a failure in one cleanup step doesn't prevent others from runningbeforeEach/afterEachinstead ofbefore/afterso each test gets a clean agent statedc.channel(...)declaration to the top of the fileTest plan
PLUGINS=ws npm run test:pluginspasses