[chores] Guard NPM publish with approvals on release PR#2066
Merged
[chores] Guard NPM publish with approvals on release PR#2066
Conversation
brett0000FF
approved these changes
Jan 20, 2026
GabrielAnca
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Follow up of #2063 to prevent people from approving NPM publish before the release PR is approved.
How?
Releasing requires 2 approvals:
npm-publishjob to allow the NPM deploymentBefore this PR, there was no mandatory order. So an admin could easily approve the
npm-publishjob before the release PR itself is approved, which could lead to organizational problems.Review checklist