Skip to content

Skip test that hates old Python in CI#5515

Merged
adamnovak merged 1 commit into
masterfrom
issues/5501-skip-broken-test
May 7, 2026
Merged

Skip test that hates old Python in CI#5515
adamnovak merged 1 commit into
masterfrom
issues/5501-skip-broken-test

Conversation

@adamnovak
Copy link
Copy Markdown
Member

This sweeps #5501 under the rug by skipping this new test in the environments it doesn't succeed in for reasons we can't reproduce.

I'm not sure if we'll still see flaky failures of test_run_and_cancel_workflows if it wins the race naturally and winning the race means a SYSTEM_ERROR in CI on Python <3.14.

Changelog Entry

To be copied to the draft changelog by merger:

  • PR submitter writes their recommendation for a changelog entry here

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
  • Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@adamnovak adamnovak merged commit 7da318b into master May 7, 2026
3 checks passed
@adamnovak adamnovak deleted the issues/5501-skip-broken-test branch May 7, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant