Skip to content

build: allow overriding docker UID for rootless environments #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Suraj-kumar00 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: allow overriding docker UID for rootless environments #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ Usage: ./$(basename "${0}")
Environmental variables:
EC_BOARD_VENDOR name of the board vendor (required)
EC_BOARD_MODEL name of the board model (required)
DOCKER_UID user ID to run Docker container as (default: current user ID)
Set to 'root' for rootless Docker setups

Example usage to build for NovaCustom NV40 series:
EC_BOARD_VENDOR=clevo EC_BOARD_MODEL=nv40mz ./$(basename "$0")
Expand Down Expand Up @@ -70,7 +72,8 @@ if [ "$EC_BOARD_VENDOR" = "novacustom" ] ; then
esac
fi

docker run --rm -v "$PWD":"$PWD" -w "$PWD" -u "$(id -u)" \
DOCKER_UID="${DOCKER_UID:-$(id -u)}"
docker run --rm -v "$PWD":"$PWD" -w "$PWD" -u "$DOCKER_UID" \
ghcr.io/dasharo/ec-sdk:main make BOARD="${EC_BOARD_VENDOR}/${EC_BOARD_MODEL}"
errorCheck "Failed to build EC firmware"

Expand Down